Fixed a few obvious errors pointed out by the static analyzer.

llvm-svn: 181911

lldb/source/API/SBCommunication.cpp

@@ -188,7 +188,6 @@ SBCommunication::ReadThreadStart ()
     if (m_opaque)
         success = m_opaque->StartReadThread ();
 
-    log = lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API);
     if (log)
         log->Printf ("SBCommunication(%p)::ReadThreadStart () => %i", m_opaque, success);
 

lldb/source/API/SBFrame.cpp

@@ -678,7 +678,7 @@ SBFrame::GetValueForVariablePath (const char *var_path, DynamicValueType use_dyn
     
     ExecutionContext exe_ctx (m_opaque_sp.get(), api_locker);
 
-    StackFrame *frame = exe_ctx.GetFramePtr();
+    StackFrame *frame = NULL;
     Target *target = exe_ctx.GetTargetPtr();
     Process *process = exe_ctx.GetProcessPtr();
     if (target && process)

lldb/source/Core/DataExtractor.cpp

@@ -1132,6 +1132,9 @@ uint64_t
 DataExtractor::GetULEB128 (offset_t *offset_ptr) const
 {
     const uint8_t *src = (const uint8_t *)PeekData (*offset_ptr, 1);
+    if (src == NULL)
+        return 0;
+    
     const uint8_t *end = m_end;
     
     if (src < end)
@@ -1169,6 +1172,9 @@ int64_t
 DataExtractor::GetSLEB128 (offset_t *offset_ptr) const
 {
     const uint8_t *src = (const uint8_t *)PeekData (*offset_ptr, 1);
+    if (src == NULL)
+        return 0;
+    
     const uint8_t *end = m_end;
     
     if (src < end)
@@ -1213,6 +1219,9 @@ DataExtractor::Skip_LEB128 (offset_t *offset_ptr) const
 {
     uint32_t bytes_consumed = 0;
     const uint8_t *src = (const uint8_t *)PeekData (*offset_ptr, 1);
+    if (src == NULL)
+        return 0;
+        
     const uint8_t *end = m_end;
     
     if (src < end)

lldb/source/Core/Debugger.cpp

@@ -1174,7 +1174,8 @@ ScanFormatDescriptor (const char* var_name_begin,
                     *val_obj_display = ValueObject::eValueObjectRepresentationStyleType;
                     break;
                 default:
-                    log->Printf("ScanFormatDescriptor] %s is an error, leaving the previous value alone", format_name.c_str());
+                    if (log)
+                        log->Printf("ScanFormatDescriptor] %s is an error, leaving the previous value alone", format_name.c_str());
                     break;
             }
         }

lldb/source/DataFormatters/Cocoa.cpp

@@ -57,7 +57,7 @@ lldb_private::formatters::NSBundleSummaryProvider (ValueObject& valobj, Stream&
         uint64_t offset = 5 * ptr_size;
         ClangASTType type(valobj.GetClangAST(),ClangASTContext::GetBuiltInType_objc_id(valobj.GetClangAST()));
         ValueObjectSP text(valobj.GetSyntheticChildAtOffset(offset, type, true));
-        valobj_addr = text->GetValueAsUnsigned(0);
+
         StreamString summary_stream;
         bool was_nsstring_ok = NSStringSummaryProvider(*text.get(), summary_stream);
         if (was_nsstring_ok && summary_stream.GetSize() > 0)

lldb/source/Expression/ClangExpressionDeclMap.cpp

@@ -1365,7 +1365,7 @@ ClangExpressionDeclMap::FindExternalVisibleDecls (NameSearchContext &context,
                 }
             }
             
-            if (!context.m_found.variable && !namespace_decl)
+            if (target && !context.m_found.variable && !namespace_decl)
             {
                 // We couldn't find a non-symbol variable for this.  Now we'll hunt for a generic 
                 // data symbol, and -- if it is found -- treat it as a variable.

lldb/source/Expression/ClangExpressionParser.cpp

@@ -550,7 +550,7 @@ ClangExpressionParser::PrepareForExecution (lldb::addr_t &func_addr,
         
         if (execution_policy == eExecutionPolicyAlways || !can_interpret)
         {
-            if (!process->GetDynamicCheckers() && m_expr.NeedsValidation())
+            if (m_expr.NeedsValidation() && (process && (!process->GetDynamicCheckers())))
             {                
                 DynamicCheckerFunctions *dynamic_checkers = new DynamicCheckerFunctions();
                 

lldb/source/Expression/IRMemoryMap.cpp

@@ -70,7 +70,7 @@ IRMemoryMap::FindSpace (size_t size)
     
     for (int iterations = 0; iterations < 16; ++iterations)
     {
-        lldb::addr_t candidate;
+        lldb::addr_t candidate = LLDB_INVALID_ADDRESS;
         
         switch (target_sp->GetArchitecture().GetAddressByteSize())
         {

lldb/source/Host/common/FileSpec.cpp

@@ -980,6 +980,8 @@ FileSpec::EnumerateDirectory
                             {
                                 // The subdirectory returned Quit, which means to 
                                 // stop all directory enumerations at all levels.
+                                if (buf)
+                                    free (buf);
                                 return eEnumerateDirectoryResultQuit;
                             }
                             break;

lldb/source/Host/common/Host.cpp

@@ -696,6 +696,8 @@ Host::SetThreadName (lldb::pid_t pid, lldb::tid_t tid, const char *name)
         }
     }
     return false;
+#else
+    return false;
 #endif
 }