replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't adjust for alignment padding in OffsetIsInRange. 

This adjustment is already included in the block offsets computed by
BasicBlockInfo, and adjusting again here can cause the pass to loop.

When CreateNewWater splits a basic block, OffsetIsInRange would reject
the new CPE on the next pass because of the too conservative alignment
adjustment. This caused the block to be split again, and so on.

llvm-svn: 146751
This commit is contained in:
Jakob Stoklund Olesen 2011-12-16 19:10:00 +00:00
parent 9ca2e7293b
commit 5af144809e
1 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
llvm/lib/Target/ARM/ARMConstantIslandPass.cpp
View File

@ -934,23 +934,8 @@ bool ARMConstantIslands::OffsetIsInRange(unsigned UserOffset,
// purposes of the displacement computation; compensate for that here. // purposes of the displacement computation; compensate for that here.
// Effectively, the valid range of displacements is 2 bytes smaller for such // Effectively, the valid range of displacements is 2 bytes smaller for such
// references. // references.
unsigned TotalAdj = 0; if (isThumb && UserOffset%4 !=0)
if (isThumb && UserOffset%4 !=0) {
UserOffset -= 2; UserOffset -= 2;
TotalAdj = 2;
}
// CPEs will be rounded up to a multiple of 4.
if (isThumb && TrialOffset%4 != 0) {
TrialOffset += 2;
TotalAdj += 2;
}
// In Thumb2 mode, later branch adjustments can shift instructions up and
// cause alignment change. In the worst case scenario this can cause the
// user's effective address to be subtracted by 2 and the CPE's address to
// be plus 2.
if (isThumb2 && TotalAdj != 4)
MaxDisp -= (4 - TotalAdj);
if (UserOffset <= TrialOffset) { if (UserOffset <= TrialOffset) {
// User before the Trial. // User before the Trial.