replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Many of Daniel's fixes. 

I'm returning the number of bytes actually copied so that the client has some
warning when it reads past the end of the buffer.

I'm keeping the distinction between getByte() and getBytes() for now for
subclasses that use functions like ptrace() on Linux and only have a restricted
interface.  This makes their implementation easier, and subclasses can always
write a one-line implementation of readByte() that uses their custom 
readBytes().

llvm-svn: 77225
This commit is contained in:
Sean Callanan 2009-07-27 18:33:24 +00:00
parent 4d37791bc3
commit 5908cfedbb
1 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
llvm/include/llvm/Support/MemoryObject.h
View File

@ -19,21 +19,21 @@ namespace llvm {
/// file, or on a remote machine. /// file, or on a remote machine.
class MemoryObject { class MemoryObject {
public: public:
/// Constructor - Override as necessary. /// Destructor - Override as necessary.
MemoryObject() { ~MemoryObject() {
} }
/// getBase - Returns the lowest valid address in the region. /// getBase - Returns the lowest valid address in the region.
/// ///
/// @result - The lowest valid address. /// @result - The lowest valid address.
virtual uint64_t getBase() const = 0; virtual uintptr_t getBase() const = 0;
/// getExtent - Returns the size of the region in bytes. (The region is /// getExtent - Returns the size of the region in bytes. (The region is
/// contiguous, so the highest valid address of the region /// contiguous, so the highest valid address of the region
/// is getBase() + getExtent() - 1). /// is getBase() + getExtent() - 1).
/// ///
/// @result - The size of the region. /// @result - The size of the region.
virtual uint64_t getExtent() const = 0; virtual uintptr_t getExtent() const = 0;
/// readByte - Tries to read a single byte from the region. /// readByte - Tries to read a single byte from the region.
/// ///
@ -41,7 +41,7 @@ public:
/// @param ptr - A pointer to a byte to be filled in. Must be non-NULL. /// @param ptr - A pointer to a byte to be filled in. Must be non-NULL.
/// @result - 0 if successful; -1 if not. Failure may be due to a /// @result - 0 if successful; -1 if not. Failure may be due to a
/// bounds violation or an implementation-specific error. /// bounds violation or an implementation-specific error.
virtual int readByte(uint64_t address, uint8_t* ptr) const = 0; virtual int readByte(uintptr_t address, uint8_t* ptr) const = 0;
/// readByte - Tries to read a contiguous range of bytes from the /// readByte - Tries to read a contiguous range of bytes from the
/// region, up to the end of the region. /// region, up to the end of the region.
@ -53,25 +53,24 @@ public:
/// @param size - The maximum number of bytes to copy. /// @param size - The maximum number of bytes to copy.
/// @param buf - A pointer to a buffer to be filled in. Must be non-NULL /// @param buf - A pointer to a buffer to be filled in. Must be non-NULL
/// and large enough to hold size bytes. /// and large enough to hold size bytes.
/// @result - The number of bytes copied if successful; (uint64_t)-1 /// @result - The number of bytes copied if successful; (uintptr_t)-1
/// if not. /// if not.
/// Failure may be due to a bounds violation or an /// Failure may be due to a bounds violation or an
/// implementation-specific error. /// implementation-specific error.
virtual uint64_t readBytes(uint64_t address, virtual uintptr_t readBytes(uintptr_t address,
uint64_t size, uintptr_t size,
uint8_t* buf) const { uint8_t* buf) const {
uint64_t current = address; uintptr_t current = address;
uint64_t limit = getBase() + getExtent(); uintptr_t limit = getBase() + getExtent();
uint64_t ret = 0;
while(current - address < size && current < limit) { while(current - address < size && current < limit) {
if(readByte(current, &buf[(current - address)])) if(readByte(current, &buf[(current - address)]))
return (uint64_t)-1; return (uintptr_t)-1;
ret++; current++;
} }
return ret; return current - address;
} }
}; };