From 58b3749d6cdbc3de390a3ee280a3065e7b4fa9b1 Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Mon, 5 Sep 2011 05:47:35 +0000 Subject: [PATCH] Enable -Wdangling-fields by default in Clang. I've run this warning over a very large chunk of code and found zero false positives. I've only found a few bugs, but that likely is because bugs of this nature actually do manifest. We've also identified several bugs that were caught by Valgrind, but would have been caught faster and more easily with this warning. If anyone has concerns, or this causes fallout on any build bots, lemme know. I'm happy to just put it under -Wmost. llvm-svn: 139112 --- clang/include/clang/Basic/DiagnosticSemaKinds.td | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/clang/include/clang/Basic/DiagnosticSemaKinds.td b/clang/include/clang/Basic/DiagnosticSemaKinds.td index 4a019bbf8ff6..f0c7a5cad478 100644 --- a/clang/include/clang/Basic/DiagnosticSemaKinds.td +++ b/clang/include/clang/Basic/DiagnosticSemaKinds.td @@ -4358,13 +4358,13 @@ def note_ref_var_local_bind : Note< // a constructor parameter. def warn_bind_ref_member_to_parameter : Warning< "binding reference member %0 to stack allocated parameter %1">, - InGroup>, DefaultIgnore; + InGroup>; def warn_init_ptr_member_to_parameter_addr : Warning< "initializing pointer member %0 with the stack address of parameter %1">, - InGroup>, DefaultIgnore; + InGroup>; def warn_bind_ref_member_to_temporary : Warning< "binding reference member %0 to a temporary value">, - InGroup>, DefaultIgnore; + InGroup>; def note_ref_or_ptr_member_declared_here : Note< "%select{reference|pointer}0 member declared here">;