replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[X86][x32] Save callee-save register used as base pointer for x32 ABI 

For the x32 ABI, since the base pointer register (EBX) is a callee save register
it should be saved before use.

This fixes https://bugs.llvm.org/show_bug.cgi?id=36011

Differential Revision: https://reviews.llvm.org/D42358

Patch by Pratik Bhatu

llvm-svn: 326593
This commit is contained in:
Derek Schuff 2018-03-02 17:46:39 +00:00
parent 4925653555
commit 57feeed307
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
llvm/lib/Target/X86/X86FrameLowering.cpp
View File

@ -2108,8 +2108,12 @@ void X86FrameLowering::determineCalleeSaves(MachineFunction &MF,
TargetFrameLowering::determineCalleeSaves(MF, SavedRegs, RS);
// Spill the BasePtr if it's used.
if (TRI->hasBasePointer(MF))
SavedRegs.set(TRI->getBaseRegister());
if (TRI->hasBasePointer(MF)){
unsigned BasePtr = TRI->getBaseRegister();
if (STI.isTarget64BitILP32())
BasePtr = getX86SubSuperRegister(BasePtr, 64);
SavedRegs.set(BasePtr);
}
}
static bool

4
llvm/test/CodeGen/X86/x86-64-baseptr.ll
View File

@ -39,6 +39,7 @@ define void @base() #0 {
; X32ABI: # %bb.0: # %entry
; X32ABI-NEXT: pushq %rbp
; X32ABI-NEXT: movl %esp, %ebp
; X32ABI-NEXT: pushq %rbx
; X32ABI-NEXT: andl $-32, %esp
; X32ABI-NEXT: subl $32, %esp
; X32ABI-NEXT: movl %esp, %ebx
@ -52,7 +53,8 @@ define void @base() #0 {
; X32ABI-NEXT: movl %edx, %esp
; X32ABI-NEXT: negl %eax
; X32ABI-NEXT: movl $0, (%ecx,%eax)
; X32ABI-NEXT: movl %ebp, %esp
; X32ABI-NEXT: leal -8(%ebp), %esp
; X32ABI-NEXT: popq %rbx
; X32ABI-NEXT: popq %rbp
; X32ABI-NEXT: retq
entry: