replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

slightly simplify some code, pull the 'is simple asm' case up in 

ConvertAsmString and shrink it a bit.  No functionality change.

llvm-svn: 66520
This commit is contained in:
Chris Lattner 2009-03-10 04:38:46 +00:00
parent ac8ea533d6
commit 57e673772e
1 changed files with 29 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
clang/lib/CodeGen/CGStmt.cpp
View File

@ -680,37 +680,44 @@ void CodeGenFunction::EmitSwitchStmt(const SwitchStmt &S) {
CaseRangeBlock = SavedCRBlock;
}
static std::string ConvertAsmString(const AsmStmt& S, bool &Failed)
{
// FIXME: No need to create new std::string here, we could just make sure
// that we don't read past the end of the string data.
std::string str(S.getAsmString()->getStrData(),
S.getAsmString()->getByteLength());
const char *Start = str.c_str();
unsigned NumOperands = S.getNumOutputs() + S.getNumInputs();
bool IsSimple = S.isSimple();
/// ConvertAsmString - Convert the GNU-style asm string to the LLVM-style asm
/// string.
static std::string ConvertAsmString(const AsmStmt& S, bool &Failed) {
Failed = false;
static unsigned AsmCounter = 0;
AsmCounter++;
std::string Result;
if (IsSimple) {
while (*Start) {
switch (*Start) {
default:
Result += *Start;
break;
const char *StrStart = S.getAsmString()->getStrData();
const char *StrEnd = StrStart + S.getAsmString()->getByteLength();
// "Simple" inline asms have no constraints or operands, just convert the asm
// string to escape $'s.
if (S.isSimple()) {
std::string Result;
for (; StrStart != StrEnd; ++StrStart) {
switch (*StrStart) {
case '$':
Result += "$$";
break;
default:
Result += *StrStart;
break;
}
Start++;
}
return Result;
}
// FIXME: No need to create new std::string here, we could just make sure
// that we don't read past the end of the string data.
std::string str(StrStart, StrEnd);
std::string Result;
const char *Start = str.c_str();
unsigned NumOperands = S.getNumOutputs() + S.getNumInputs();
// FIXME: Static counters are not thread safe or reproducible.
static unsigned AsmCounter = 0;
AsmCounter++;
while (*Start) {
switch (*Start) {
default:
@ -889,8 +896,7 @@ llvm::Value* CodeGenFunction::EmitAsmInput(const AsmStmt &S,
void CodeGenFunction::EmitAsmStmt(const AsmStmt &S) {
bool Failed;
std::string AsmString =
ConvertAsmString(S, Failed);
std::string AsmString = ConvertAsmString(S, Failed);
if (Failed) {
ErrorUnsupported(&S, "asm string");