replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[Remarks][NFC] Improve testing and documentation of -foptimization-record-passes 

This adds:

* documentation to the user manual
* nicer error message
* test for the error case
* test for the gold plugin

llvm-svn: 363463
This commit is contained in:
Francis Visoiu Mistrih 2019-06-14 21:38:57 +00:00
parent 282dac717e
commit 5501dda247
4 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
clang/docs/UsersManual.rst
View File

@ -345,6 +345,18 @@ output format of the diagnostics that it generates.
after the primary file being compiled. If that's "foo.c", for example,
optimization records are output to "foo.opt.yaml".
.. _opt_foptimization-record-passes:
**-foptimization-record-passes**
Only include passes which match a specified regular expression.
When optimization reports are being output (see
:ref:`-fsave-optimization-record <opt_fsave-optimization-record>`), this
option controls the passes that will be included in the final report.
If this option is not used, all the passes are included in the optimization
record.
.. _opt_fdiagnostics-show-hotness:
**-f[no-]diagnostics-show-hotness**

2
clang/include/clang/Basic/DiagnosticDriverKinds.td
View File

@ -229,7 +229,7 @@ def err_drv_gnustep_objc_runtime_incompatible_binary : Error<
def err_drv_emit_llvm_link : Error<
"-emit-llvm cannot be used when linking">;
def err_drv_optimization_remark_pattern : Error<
"%0 in '%1'">;
"in pattern '%1': %0">;
def err_drv_no_neon_modifier : Error<"[no]neon is not accepted as modifier, please use [no]simd instead">;
def err_drv_invalid_omp_target : Error<"OpenMP target is invalid: '%0'">;
def err_drv_omp_host_ir_file_not_found : Error<

3
clang/test/CodeGen/opt-record.c
View File

@ -5,6 +5,7 @@
// RUN: cat %t.yaml | FileCheck -check-prefix=CHECK -check-prefix=CHECK-PGO %s
// RUN: %clang_cc1 -O3 -triple x86_64-unknown-linux-gnu -target-cpu x86-64 %s -o %t -dwarf-column-info -opt-record-file %t.yaml -opt-record-passes inline -emit-obj
// RUN: cat %t.yaml | FileCheck -check-prefix=CHECK-PASSES %s
// RUN: not %clang_cc1 -O3 -triple x86_64-unknown-linux-gnu -target-cpu x86-64 %s -o %t -dwarf-column-info -opt-record-file %t.yaml -opt-record-passes "(foo" -emit-obj 2>&1 | FileCheck -check-prefix=CHECK-PATTERN-ERROR %s
// REQUIRES: x86-registered-target
void bar();
@ -34,3 +35,5 @@ void Test(int *res, int *c, int *d, int *p, int n) {
// CHECK: Function: Test
// CHECK-PGO: Hotness:
// CHECK-PASSES-NOT: loop-vectorize
// CHECK-PATTERN-ERROR: error: in pattern '(foo': parentheses not balanced

2
llvm/test/tools/gold/X86/opt-remarks.ll
View File

@ -2,9 +2,11 @@
; RUN: llvm-as %s -o %t.o
; RUN: %gold -m elf_x86_64 -plugin %llvmshlibdir/LLVMgold%shlibext -shared \
; RUN: -plugin-opt=save-temps \
; RUN: -plugin-opt=opt-remarks-passes=inline \
; RUN: -plugin-opt=opt-remarks-filename=%t.yaml %t.o -o %t2.o 2>&1
; RUN: llvm-dis %t2.o.0.4.opt.bc -o - | FileCheck %s
; RUN: %gold -m elf_x86_64 -plugin %llvmshlibdir/LLVMgold%shlibext -shared \
; RUN: -plugin-opt=opt-remarks-passes=inline \
; RUN: -plugin-opt=opt-remarks-with-hotness \
; RUN: -plugin-opt=opt-remarks-filename=%t.hot.yaml %t.o -o %t2.o 2>&1
; RUN: cat %t.yaml | FileCheck %s -check-prefix=YAML