replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[PowerPC] Adjust PatchPoints for ppc64le 

Bill Schmidt pointed out that some adjustments would be needed to properly
support powerpc64le (using the ELF V2 ABI). For one thing, R11 is not available
as a scratch register, so we need to use R12. R12 is also available under ELF
V1, so to maintain consistency, I flipped the order to make R12 the first
scratch register in the array under both ABIs.

llvm-svn: 226247
This commit is contained in:
Hal Finkel 2015-01-16 04:40:58 +00:00
parent 6fffd487ee
commit 52f7c018d3
3 changed files with 34 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
llvm/docs/StackMaps.rst
View File

@ -221,11 +221,12 @@ lowered according to the calling convention specified at the
intrinsic's callsite. Variants of the intrinsic with non-void return intrinsic's callsite. Variants of the intrinsic with non-void return
type also return a value according to calling convention. type also return a value according to calling convention.
On PowerPC, note that the ``<target>`` must be the actual intended target of On PowerPC, note that ``<target>`` must be the actual intended target of
the indirect call, not the function-descriptor address normally used as the the indirect call. Specifically, even when compiling for the ELF V1 ABI,
C/C++ function-pointer representation. As a result, the call target must be ``<target>`` is not the function-descriptor address normally used as the C/C++
local because no adjustment or restoration of the TOC pointer (in register r2) function-pointer representation. As a result, the call target must be local
will be performed. because no adjustment or restoration of the TOC pointer (in register r2) will
be performed.
Requesting zero patch point arguments is valid. In this case, all Requesting zero patch point arguments is valid. In this case, all
variable operands are handled just like variable operands are handled just like

10
llvm/lib/Target/PowerPC/PPCISelLowering.cpp
View File

@ -9910,8 +9910,16 @@ PPCTargetLowering::getScratchRegisters(CallingConv::ID) const {
// site. Hence we include LR in the scratch registers, which are in turn added // site. Hence we include LR in the scratch registers, which are in turn added
// as implicit-defs for stackmaps and patchpoints. The same reasoning applies // as implicit-defs for stackmaps and patchpoints. The same reasoning applies
// to CTR, which is used by any indirect call. // to CTR, which is used by any indirect call.
if (Subtarget.isELFv2ABI()) {
static const MCPhysReg ScratchRegs[] = {
PPC::X12, PPC::LR8, PPC::CTR8, 0
};
return ScratchRegs;
}
static const MCPhysReg ScratchRegs[] = { static const MCPhysReg ScratchRegs[] = {
PPC::X11, PPC::X12, PPC::LR8, PPC::CTR8, 0 PPC::X12, PPC::X11, PPC::LR8, PPC::CTR8, 0
}; };
return ScratchRegs; return ScratchRegs;

34
llvm/test/CodeGen/PowerPC/ppc64-patchpoint.ll
View File

@ -1,6 +1,8 @@
; RUN: llc < %s | FileCheck %s ; RUN: llc < %s | FileCheck %s -check-prefix=CHECK -check-prefix=CHECK-BE
; RUN: llc -fast-isel -fast-isel-abort < %s | FileCheck %s ; RUN: llc -fast-isel -fast-isel-abort < %s | FileCheck %s -check-prefix=CHECK -check-prefix=CHECK-BE
target datalayout = "E-m:e-i64:64-n32:64" ; RUN: llc -mtriple=powerpc64le-unknown-linux-gnu < %s | FileCheck %s -check-prefix=CHECK -check-prefix=CHECK-LE
; RUN: llc -mtriple=powerpc64le-unknown-linux-gnu -fast-isel -fast-isel-abort < %s | FileCheck %s -check-prefix=CHECK -check-prefix=CHECK-LE
target triple = "powerpc64-unknown-linux-gnu" target triple = "powerpc64-unknown-linux-gnu"
; Trivial patchpoint codegen ; Trivial patchpoint codegen
@ -9,18 +11,18 @@ define i64 @trivial_patchpoint_codegen(i64 %p1, i64 %p2, i64 %p3, i64 %p4) {
entry: entry:
; CHECK-LABEL: trivial_patchpoint_codegen: ; CHECK-LABEL: trivial_patchpoint_codegen:
; CHECK: li 11, -8531 ; CHECK: li 12, -8531
; CHECK-NEXT: rldic 11, 11, 32, 16 ; CHECK-NEXT: rldic 12, 12, 32, 16
; CHECK-NEXT: oris 11, 11, 48879 ; CHECK-NEXT: oris 12, 12, 48879
; CHECK-NEXT: ori 11, 11, 51966 ; CHECK-NEXT: ori 12, 12, 51966
; CHECK-NEXT: mtctr 11 ; CHECK-NEXT: mtctr 12
; CHECK-NEXT: bctrl ; CHECK-NEXT: bctrl
; CHECK: li 11, -8531 ; CHECK: li 12, -8531
; CHECK-NEXT: rldic 11, 11, 32, 16 ; CHECK-NEXT: rldic 12, 12, 32, 16
; CHECK-NEXT: oris 11, 11, 48879 ; CHECK-NEXT: oris 12, 12, 48879
; CHECK-NEXT: ori 11, 11, 51967 ; CHECK-NEXT: ori 12, 12, 51967
; CHECK-NEXT: mtctr 11 ; CHECK-NEXT: mtctr 12
; CHECK-NEXT: bctrl ; CHECK-NEXT: bctrl
; CHECK: blr ; CHECK: blr
@ -36,9 +38,11 @@ entry:
; as a leaf function. ; as a leaf function.
; ;
; CHECK-LABEL: caller_meta_leaf ; CHECK-LABEL: caller_meta_leaf
; CHECK: stdu 1, -80(1) ; CHECK-BE: stdu 1, -80(1)
; CHECK-LE: stdu 1, -64(1)
; CHECK: Ltmp ; CHECK: Ltmp
; CHECK: addi 1, 1, 80 ; CHECK-BE: addi 1, 1, 80
; CHECK-LE: addi 1, 1, 64
; CHECK: blr ; CHECK: blr
define void @caller_meta_leaf() { define void @caller_meta_leaf() {