replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add the fix that should've accompanied r213738. 

llvm-svn: 213740
This commit is contained in:
Benjamin Kramer 2014-07-23 11:50:54 +00:00
parent d025f90c99
commit 4ff1ffa1ce
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
clang-tools-extra/clang-tidy/misc/UnusedRAII.cpp
View File

@ -34,7 +34,6 @@ void UnusedRAIICheck::registerMatchers(MatchFinder *Finder) {
anyOf(recordDecl(ast_matchers::isTemplateInstantiation()),
functionDecl(ast_matchers::isTemplateInstantiation()))))),
hasParent(compoundStmt().bind("compound")),
hasDescendant(typeLoc().bind("typeloc")),
hasType(recordDecl(hasUserDeclaredDestructor())),
anyOf(has(BindTemp), has(functionalCastExpr(has(BindTemp)))))
.bind("expr"),
@ -71,8 +70,12 @@ void UnusedRAIICheck::check(const MatchFinder::MatchResult &Result) {
return;
}
// Otherwise just suggest adding a name.
const auto *TL = Result.Nodes.getNodeAs<TypeLoc>("typeloc");
// Otherwise just suggest adding a name. To find the place to insert the name
// find the first TypeLoc in the children of E, which always points to the
// written type.
const auto *TL =
selectFirst<TypeLoc>("t", match(expr(hasDescendant(typeLoc().bind("t"))),
*E, *Result.Context));
D << FixItHint::CreateInsertion(
Lexer::getLocForEndOfToken(TL->getLocEnd(), 0, *Result.SourceManager,
Result.Context->getLangOpts()),