replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[Inliner] Fix a nasty bug when inlining a non-recursive trace of 

a function into itself.

We tried to fix this before in r306495 but that got reverted as the
assert was actually hit.

This fixes the original bug (which we seem to have lost track of with
the revert) by blocking a second remapping when the function being
inlined is also the caller and the remapping could succeed but
erroneously.

The included test case would actually load from an inlined copy of the
alloca before this change, failing to load the stored value and
miscompiling.

Many thanks to Richard Smith for diagnosing a user miscompile to this
bug, and to Kyle for the first attempt and initial analysis and David Li
for remembering the issue and how to fix it and suggesting the patch.
I'm just stitching it together and landing it. =]

llvm-svn: 311229
This commit is contained in:
Chandler Carruth 2017-08-19 06:56:11 +00:00
parent 2a80fddf67
commit 4f3aa29a46
2 changed files with 34 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/lib/Transforms/Utils/CloneFunction.cpp
View File

@ -341,8 +341,9 @@ void PruningFunctionCloner::CloneBlock(const BasicBlock *BB,
SimplifyInstruction(NewInst, BB->getModule()->getDataLayout())) {
// On the off-chance that this simplifies to an instruction in the old
// function, map it back into the new function.
if (Value *MappedV = VMap.lookup(V))
V = MappedV;
if (NewFunc != OldFunc)
if (Value *MappedV = VMap.lookup(V))
V = MappedV;
if (!NewInst->mayHaveSideEffects()) {
VMap[&*II] = V;

31
llvm/test/Transforms/Inline/recursive.ll
View File

@ -40,3 +40,34 @@ declare void @bar(i8* %in)
declare i32 @foo(i32 %param)
; Check that when inlining a non-recursive path into a function's own body that
; we get the re-mapping of instructions correct.
define i32 @test_recursive_inlining_remapping(i1 %init, i8* %addr) {
; CHECK-LABEL: define i32 @test_recursive_inlining_remapping(
bb:
%n = alloca i32
br i1 %init, label %store, label %load
; CHECK-NOT: alloca
;
; CHECK: %[[N:.*]] = alloca i32
; CHECK-NEXT: br i1 %init,
store:
store i32 0, i32* %n
%cast = bitcast i32* %n to i8*
%v = call i32 @test_recursive_inlining_remapping(i1 false, i8* %cast)
ret i32 %v
; CHECK-NOT: call
;
; CHECK: store i32 0, i32* %[[N]]
; CHECK-NEXT: %[[CAST:.*]] = bitcast i32* %[[N]] to i8*
; CHECK-NEXT: %[[INLINED_LOAD:.*]] = load i32, i32* %[[N]]
; CHECK-NEXT: ret i32 %[[INLINED_LOAD]]
;
; CHECK-NOT: call
load:
%castback = bitcast i8* %addr to i32*
%n.load = load i32, i32* %castback
ret i32 %n.load
}