replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Objective-C. Do not warn if user is using property-dox syntax to name a 

user provided setter name (as declared in @property attribute declaration).
rdar://18022762

llvm-svn: 215736
This commit is contained in:
Fariborz Jahanian 2014-08-15 17:39:00 +00:00
parent 5b1dbec1b4
commit 4eda2c0086
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang/lib/Sema/SemaExprObjC.cpp
View File

@ -1708,11 +1708,15 @@ HandleExprPropertyRefExpr(const ObjCObjectPointerType *OPT,
// name 'x'. // name 'x'.
if (Setter && Setter->isImplicit() && Setter->isPropertyAccessor() if (Setter && Setter->isImplicit() && Setter->isPropertyAccessor()
&& !IFace->FindPropertyDeclaration(Member)) { && !IFace->FindPropertyDeclaration(Member)) {
if (const ObjCPropertyDecl *PDecl = Setter->findPropertyDecl()) if (const ObjCPropertyDecl *PDecl = Setter->findPropertyDecl()) {
// Do not warn if user is using property-dot syntax to make call to
// user named setter.
if (!(PDecl->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_setter))
Diag(MemberLoc, Diag(MemberLoc,
diag::warn_property_access_suggest) diag::warn_property_access_suggest)
<< MemberName << QualType(OPT, 0) << PDecl->getName() << MemberName << QualType(OPT, 0) << PDecl->getName()
<< FixItHint::CreateReplacement(MemberLoc, PDecl->getName()); << FixItHint::CreateReplacement(MemberLoc, PDecl->getName());
}
} }
if (Getter || Setter) { if (Getter || Setter) {

2
clang/test/SemaObjC/property-user-setter.m
View File

@ -151,7 +151,7 @@ int main (void) {
- (void) dealloc - (void) dealloc
{ {
self.formatter = 0; // expected-warning {{property 'formatter' not found on object of type 'FMXBridgeFormatter *'; did you mean to access property cppFormatter?}} self.formatter = 0;
} }
@end @end