From 4c727853ed490d817c3f8bd6f16f75d1c71b78ba Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Mon, 30 Jan 2012 12:25:35 +0000 Subject: [PATCH] Fix yet another issue introduced when renaming '-ccc-host-triple' to '-target'. The original flag was part of a flag group that marked it as driver-only. The new flag didn't ever get equivalent treatment. This caused the '-target' flag to get passed down to any raw GCC invocation. Marking it as a driver option fixes this and PR11875. llvm-svn: 149244 --- clang/include/clang/Driver/Options.td | 2 +- clang/test/Driver/target.c | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 clang/test/Driver/target.c diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index ad36b0280f7c..f0c7f059e3bc 100644 --- a/clang/include/clang/Driver/Options.td +++ b/clang/include/clang/Driver/Options.td @@ -756,7 +756,7 @@ def stdlib_EQ : Joined<"-stdlib=">; def sub__library : JoinedOrSeparate<"-sub_library">; def sub__umbrella : JoinedOrSeparate<"-sub_umbrella">; def s : Flag<"-s">; -def target : Separate<"-target">, +def target : Separate<"-target">, Flags<[DriverOption]>, HelpText<"Generate code for the given target">; // We should deprecate the use of -ccc-host-triple, and then remove. def ccc_host_triple : Separate<"-ccc-host-triple">, Alias; diff --git a/clang/test/Driver/target.c b/clang/test/Driver/target.c new file mode 100644 index 000000000000..09f1a9b02144 --- /dev/null +++ b/clang/test/Driver/target.c @@ -0,0 +1,11 @@ +// RUN: %clang -no-canonical-prefixes -target unknown-unknown-unknown -c %s \ +// RUN: -o %t.o -### 2>&1 | FileCheck %s +// +// Ensure we get a crazy triple here as we asked for one. +// CHECK: Target: unknown-unknown-unknown +// +// Also, ensure we don't blindly hand our target selection logic down to GCC. +// CHECK: "{{.*}}gcc" +// CHECK-NOT: "-target" +// CHECK-NOT: "unknown-unknown-unknown" +// CHECK: "-x" "assembler"