replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix for PR16570: when comparing two function pointers, discard qualifiers when 

comparing non-reference function parameters.  The qualifiers don't matter for
comparisons.

This is a re-commit of r187769, which was accidentially reverted in r187770,
with a simplification at the suggestion of Eli Friedman.

llvm-svn: 188112
This commit is contained in:
Richard Trieu 2013-08-09 21:42:32 +00:00
parent 6dac00702c
commit 4b03d98858
2 changed files with 54 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clang/lib/Sema/SemaOverload.cpp
View File

@ -2584,7 +2584,8 @@ bool Sema::FunctionArgTypesAreEqual(const FunctionProtoType *OldType,
for (FunctionProtoType::arg_type_iterator O = OldType->arg_type_begin(),
N = NewType->arg_type_begin(),
E = OldType->arg_type_end(); O && (O != E); ++O, ++N) {
if (!Context.hasSameType(*O, *N)) {
if (!Context.hasSameType(O->getUnqualifiedType(),
N->getUnqualifiedType())) {
if (ArgPos) *ArgPos = O - OldType->arg_type_begin();
return false;
}

52
clang/test/SemaCXX/function-pointer-arguments.cpp Normal file
View File

@ -0,0 +1,52 @@
//RUN: %clang_cc1 -fsyntax-only -verify %s
namespace PR16570 {
int f1(int, int);
int f2(const int, int);
int f3(int&, int);
int f4(const int&, int);
void good() {
int(*g1)(int, int) = f1;
int(*g2)(const int, int) = f1;
int(*g3)(volatile int, int) = f1;
int(*g4)(int, int) = f2;
int(*g5)(const int, int) = f2;
int(*g6)(volatile int, int) = f2;
int(*g7)(int&, int) = f3;
int(*g8)(const int&, int) = f4;
}
void bad() {
void (*g1)(int, int) = f1;
// expected-error@-1 {{different return type ('void' vs 'int'}}
const int (*g2)(int, int) = f1;
// expected-error@-1 {{different return type ('const int' vs 'int')}}
int (*g3)(char, int) = f1;
// expected-error@-1 {{type mismatch at 1st parameter ('char' vs 'int')}}
int (*g4)(int, char) = f1;
// expected-error@-1 {{type mismatch at 2nd parameter ('char' vs 'int')}}
int (*g5)(int) = f1;
// expected-error@-1 {{different number of parameters (1 vs 2)}}
int (*g6)(int, int, int) = f1;
// expected-error@-1 {{different number of parameters (3 vs 2)}}
int (*g7)(const int, char) = f1;
// expected-error@-1 {{type mismatch at 2nd parameter ('char' vs 'int')}}
int (*g8)(int, char) = f2;
// expected-error@-1 {{type mismatch at 2nd parameter ('char' vs 'int')}}
int (*g9)(const int&, char) = f3;
// expected-error@-1 {{type mismatch at 1st parameter ('const int &' vs 'int &')}}
int (*g10)(int&, char) = f4;
// expected-error@-1 {{type mismatch at 1st parameter ('int &' vs 'const int &')}}
}
typedef void (*F)(const char * __restrict__, int);
void g(const char *, unsigned);
F f = g;
// expected-error@-1 {{type mismatch at 2nd parameter ('int' vs 'unsigned int')}}
}