replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[ELF] - Fix functionality treating IFunc definitions in DSOs as functions. 

It was intially implemented in D19517 but then broken.
Patch fixes PR33707, testcase is based on PR's case.

Differential revision: https://reviews.llvm.org/D35119

llvm-svn: 307652
This commit is contained in:
George Rimar 2017-07-11 11:40:59 +00:00
parent 54df93d60e
commit 4a9cfc8267
3 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lld/ELF/Symbols.h
View File

@ -218,7 +218,7 @@ public:
Verdef(Verdef), ElfSym(ElfSym) {
// IFuncs defined in DSOs are treated as functions by the static linker.
if (isGnuIFunc())
Type = llvm::ELF::STT_FUNC;
this->Type = llvm::ELF::STT_FUNC;
this->File = File;
}

3
lld/test/ELF/Inputs/gnu-ifunc-dso.s Normal file
View File

@ -0,0 +1,3 @@
.type foo STT_GNU_IFUNC
.globl foo
foo:

13
lld/test/ELF/gnu-ifunc-dso.s Normal file
View File

@ -0,0 +1,13 @@
# REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %S/Inputs/gnu-ifunc-dso.s -o %t1.o
# RUN: ld.lld -shared %t1.o -o %t.so
# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t2.o
# RUN: ld.lld -shared %t2.o %t.so -o %t
# RUN: llvm-readobj -dyn-relocations %t | FileCheck %s
# CHECK: Dynamic Relocations {
# CHECK-NEXT: 0x1000 R_X86_64_64 foo 0x0
# CHECK-NEXT: }
.data
.quad foo