replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[ExecutionEngine] Rename JITSymbol::isStrongDefinition to isStrong. 

For symmetry with isWeak, isCommon.

llvm-svn: 322594
This commit is contained in:
Lang Hames 2018-01-16 20:39:51 +00:00
parent cc64266f53
commit 4a793c0667
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/include/llvm/ExecutionEngine/JITSymbol.h
View File

@ -89,7 +89,7 @@ public:
}
/// @brief Returns true if the symbol isn't weak or common.
bool isStrongDefinition() const {
bool isStrong() const {
return !isWeak() && !isCommon();
}

6
llvm/lib/ExecutionEngine/Orc/Core.cpp
View File

@ -190,13 +190,13 @@ VSO::RelativeLinkageStrength VSO::compareLinkage(Optional<JITSymbolFlags> Old,
if (Old == None)
return llvm::orc::VSO::NewDefinitionIsStronger;
if (Old->isStrongDefinition()) {
if (New.isStrongDefinition())
if (Old->isStrong()) {
if (New.isStrong())
return llvm::orc::VSO::DuplicateDefinition;
else
return llvm::orc::VSO::ExistingDefinitionIsStronger;
} else {
if (New.isStrongDefinition())
if (New.isStrong())
return llvm::orc::VSO::NewDefinitionIsStronger;
else
return llvm::orc::VSO::ExistingDefinitionIsStronger;

2
llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp
View File

@ -247,7 +247,7 @@ RuntimeDyldImpl::loadObjectImpl(const object::ObjectFile &Obj) {
// Then check the symbol resolver to see if there's a definition
// elsewhere in this logical dylib.
if (auto Sym = Resolver.findSymbolInLogicalDylib(Name)) {
if (Sym.getFlags().isStrongDefinition())
if (Sym.getFlags().isStrong())
continue;
} else if (auto Err = Sym.takeError())
return std::move(Err);