replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

When doing int<->ptr coercion for big-endian, calculate the shift amount correctly. 

Previously we calculated the shift amount based upon DataLayout::getTypeAllocSizeInBits.
This will only work for legal types - types such as i24 that are created as part of
structs for bitfields will return "32" from that function. Change to using
getTypeSizeInBits.

It turns out that AArch64 didn't run across this problem because it always returned
[1 x i64] as the type for a bitfield, whereas ARM64 returns i64 so goes down this
(better, but wrong) codepath.

llvm-svn: 208231
This commit is contained in:
James Molloy 2014-05-07 17:41:15 +00:00
parent 32908d7a35
commit 491cefbe7a
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang/lib/CodeGen/CGCall.cpp
View File

@ -700,8 +700,9 @@ static llvm::Value *CoerceIntOrPtrToIntOrPtr(llvm::Value *Val,
if (DL.isBigEndian()) { if (DL.isBigEndian()) {
// Preserve the high bits on big-endian targets. // Preserve the high bits on big-endian targets.
// That is what memory coercion does. // That is what memory coercion does.
uint64_t SrcSize = DL.getTypeAllocSizeInBits(Val->getType()); uint64_t SrcSize = DL.getTypeSizeInBits(Val->getType());
uint64_t DstSize = DL.getTypeAllocSizeInBits(DestIntTy); uint64_t DstSize = DL.getTypeSizeInBits(DestIntTy);
if (SrcSize > DstSize) { if (SrcSize > DstSize) {
Val = CGF.Builder.CreateLShr(Val, SrcSize - DstSize, "coerce.highbits"); Val = CGF.Builder.CreateLShr(Val, SrcSize - DstSize, "coerce.highbits");
Val = CGF.Builder.CreateTrunc(Val, DestIntTy, "coerce.val.ii"); Val = CGF.Builder.CreateTrunc(Val, DestIntTy, "coerce.val.ii");

9
clang/test/CodeGen/arm64-be-bitfield.c Normal file
View File

@ -0,0 +1,9 @@
// RUN: %clang_cc1 -triple arm64_be-linux-gnu -ffreestanding -emit-llvm -O0 -o - %s | FileCheck %s
struct bt3 { signed b2:10; signed b3:10; } b16;
// The correct right-shift amount is 40 bits for big endian.
signed callee_b0f(struct bt3 bp11) {
// CHECK: = lshr i64 %{{.*}}, 40
return bp11.b2;
}