replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[GISel][UnitTest] Fix a bunch of tests that were not doing anything 

After r368065, all the tests using GISelMITest must call setUp() before
doing anything, otherwise the TargetMachine is not going to be set up.
A few tests added after that commit were not doing that and ended up
testing effectively nothing.

Fix the setup of all the tests and fix the failing tests.

llvm-svn: 374595
This commit is contained in:
Quentin Colombet 2019-10-11 20:58:26 +00:00
parent 9bea4ec28c
commit 49036dd3ae
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp
View File

@ -120,17 +120,16 @@ TEST_F(GISelMITest, TestKnownBits) {
}
TEST_F(GISelMITest, TestSignBitIsZero) {
setUp();
if (!TM)
return;
const LLT S32 = LLT::scalar(32);
auto SignBit = B.buildConstant(S32, 0x8000000);
auto SignBit = B.buildConstant(S32, 0x80000000);
auto Zero = B.buildConstant(S32, 0);
GISelKnownBits KnownBits(*MF);
EXPECT_TRUE(KnownBits.signBitIsZero(Zero.getReg(0)));
EXPECT_FALSE(KnownBits.signBitIsZero(Zero.getReg(0)));
EXPECT_FALSE(KnownBits.signBitIsZero(SignBit.getReg(0)));
EXPECT_TRUE(KnownBits.signBitIsZero(SignBit.getReg(0)));
}

9
llvm/unittests/CodeGen/GlobalISel/MachineIRBuilderTest.cpp
View File

@ -74,6 +74,7 @@ TEST_F(GISelMITest, TestBuildConstantFConstantDeath) {
#endif
TEST_F(GISelMITest, DstOpSrcOp) {
setUp();
if (!TM)
return;
@ -99,6 +100,7 @@ TEST_F(GISelMITest, DstOpSrcOp) {
}
TEST_F(GISelMITest, BuildUnmerge) {
setUp();
if (!TM)
return;
@ -119,6 +121,7 @@ TEST_F(GISelMITest, BuildUnmerge) {
}
TEST_F(GISelMITest, TestBuildFPInsts) {
setUp();
if (!TM)
return;
@ -154,6 +157,7 @@ TEST_F(GISelMITest, TestBuildFPInsts) {
}
TEST_F(GISelMITest, BuildIntrinsic) {
setUp();
if (!TM)
return;
@ -182,6 +186,7 @@ TEST_F(GISelMITest, BuildIntrinsic) {
}
TEST_F(GISelMITest, BuildXor) {
setUp();
if (!TM)
return;
@ -210,6 +215,7 @@ TEST_F(GISelMITest, BuildXor) {
}
TEST_F(GISelMITest, BuildBitCounts) {
setUp();
if (!TM)
return;
@ -237,6 +243,7 @@ TEST_F(GISelMITest, BuildBitCounts) {
}
TEST_F(GISelMITest, BuildCasts) {
setUp();
if (!TM)
return;
@ -261,6 +268,7 @@ TEST_F(GISelMITest, BuildCasts) {
}
TEST_F(GISelMITest, BuildMinMax) {
setUp();
if (!TM)
return;
@ -286,6 +294,7 @@ TEST_F(GISelMITest, BuildMinMax) {
}
TEST_F(GISelMITest, BuildAtomicRMW) {
setUp();
if (!TM)
return;