From 4827deb74f9aa9dc922ab68d1d3bda92d7a98585 Mon Sep 17 00:00:00 2001 From: Anton Korobeynikov Date: Thu, 3 Jul 2008 07:43:14 +0000 Subject: [PATCH] llvm-gcc sometimes marks external declarations hidden, because intializers are processed separately. Honour such situation and emit PIC relocations properly in such case. llvm-svn: 53091 --- llvm/lib/Target/X86/X86Subtarget.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/llvm/lib/Target/X86/X86Subtarget.cpp b/llvm/lib/Target/X86/X86Subtarget.cpp index b4c58496961a..fa630edb3891 100644 --- a/llvm/lib/Target/X86/X86Subtarget.cpp +++ b/llvm/lib/Target/X86/X86Subtarget.cpp @@ -47,7 +47,8 @@ bool X86Subtarget::GVRequiresExtraLoad(const GlobalValue* GV, // Extra load is needed for all externally visible. if (isDirectCall) return false; - if (GV->hasInternalLinkage() || GV->hasHiddenVisibility()) + if (GV->hasInternalLinkage() || + (GV->hasHiddenVisibility() && !GV->isDeclaration())) return false; return true; } else if (isTargetCygMing() || isTargetWindows()) {