diff --git a/llvm/lib/CodeGen/LowerSubregs.cpp b/llvm/lib/CodeGen/LowerSubregs.cpp index 9af276fad623..14acb71eeb40 100644 --- a/llvm/lib/CodeGen/LowerSubregs.cpp +++ b/llvm/lib/CodeGen/LowerSubregs.cpp @@ -165,11 +165,12 @@ bool LowerSubregsInstructionPass::LowerSubregToReg(MachineInstr *MI) { unsigned DstReg = MI->getOperand(0).getReg(); unsigned InsReg = MI->getOperand(2).getReg(); - unsigned SubIdx = MI->getOperand(3).getImm(); + unsigned InsSIdx = MI->getOperand(2).getSubReg(); + unsigned SubIdx = MI->getOperand(3).getImm(); assert(SubIdx != 0 && "Invalid index for insert_subreg"); unsigned DstSubReg = TRI.getSubReg(DstReg, SubIdx); - + assert(TargetRegisterInfo::isPhysicalRegister(DstReg) && "Insert destination must be in a physical register"); assert(TargetRegisterInfo::isPhysicalRegister(InsReg) && @@ -177,8 +178,13 @@ bool LowerSubregsInstructionPass::LowerSubregToReg(MachineInstr *MI) { DOUT << "subreg: CONVERTING: " << *MI; - if (DstSubReg == InsReg) { + if (DstSubReg == InsReg && InsSIdx == 0) { // No need to insert an identify copy instruction. + // Watch out for case like this: + // %RAX = ... + // %RAX = SUBREG_TO_REG 0, %EAX:3, 3 + // The first def is defining RAX, not EAX so the top bits were not + // zero extended. DOUT << "subreg: eliminated!"; } else { // Insert sub-register copy diff --git a/llvm/test/CodeGen/X86/subreg-to-reg-2.ll b/llvm/test/CodeGen/X86/subreg-to-reg-2.ll new file mode 100644 index 000000000000..d0b40cd5d471 --- /dev/null +++ b/llvm/test/CodeGen/X86/subreg-to-reg-2.ll @@ -0,0 +1,25 @@ +; RUN: llvm-as < %s | llc -mtriple=x86_64-apple-darwin | grep movl +; rdar://6707985 + + %XXOO = type { %"struct.XXC::XXCC", i8*, %"struct.XXC::XXOO::$_71" } + %XXValue = type opaque + %"struct.XXC::ArrayStorage" = type { i32, i32, i32, i8*, i8*, [1 x %XXValue*] } + %"struct.XXC::XXArray" = type { %XXOO, i32, %"struct.XXC::ArrayStorage"* } + %"struct.XXC::XXCC" = type { i32 (...)**, i8* } + %"struct.XXC::XXOO::$_71" = type { [2 x %XXValue*] } + +define internal fastcc %XXValue* @t(i64* %out, %"struct.XXC::ArrayStorage"* %tmp9) nounwind { +prologue: + %array = load %XXValue** inttoptr (i64 11111111 to %XXValue**) ; <%XXValue*> [#uses=0] + %index = load %XXValue** inttoptr (i64 22222222 to %XXValue**) ; <%XXValue*> [#uses=1] + %tmp = ptrtoint %XXValue* %index to i64 ; [#uses=2] + store i64 %tmp, i64* %out + %tmp6 = trunc i64 %tmp to i32 ; [#uses=1] + br label %bb5 + +bb5: ; preds = %prologue + %tmp10 = zext i32 %tmp6 to i64 ; [#uses=1] + %tmp11 = getelementptr %"struct.XXC::ArrayStorage"* %tmp9, i64 0, i32 5, i64 %tmp10 ; <%XXValue**> [#uses=1] + %tmp12 = load %XXValue** %tmp11, align 8 ; <%XXValue*> [#uses=1] + ret %XXValue* %tmp12 +}