From 47196e6cd53de018f19e38b89069b63a561e626e Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Wed, 19 Sep 2012 13:03:07 +0000 Subject: [PATCH] IntegerDivision: Style cleanups, avoid warning about mixing || and && without parens. llvm-svn: 164216 --- llvm/lib/Transforms/Utils/IntegerDivision.cpp | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/llvm/lib/Transforms/Utils/IntegerDivision.cpp b/llvm/lib/Transforms/Utils/IntegerDivision.cpp index 8589712200ff..afbfe2c1310e 100644 --- a/llvm/lib/Transforms/Utils/IntegerDivision.cpp +++ b/llvm/lib/Transforms/Utils/IntegerDivision.cpp @@ -266,16 +266,14 @@ static Value* GenerateUnsignedDivisionCode(Value* Dividend, Value* Divisor, } bool llvm::expandDivision(BinaryOperator* Div) { - assert(Div->getOpcode() == Instruction::SDiv || - Div->getOpcode() == Instruction::UDiv - && "Trying to expand division from a non-division function"); + assert((Div->getOpcode() == Instruction::SDiv || + Div->getOpcode() == Instruction::UDiv) && + "Trying to expand division from a non-division function"); IRBuilder<> Builder(Div); - if (Div->getType()->isVectorTy()) { - assert(0 && "Div over vectors not supported"); - return false; - } + if (Div->getType()->isVectorTy()) + llvm_unreachable("Div over vectors not supported"); // First prepare the sign if it's a signed division if (Div->getOpcode() == Instruction::SDiv) {