replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't leak CXStrings for replacement fix-its in c-index-test. 

The loop body used to contain a switch statement; it looks like r96685 replaced
that with an if/else if/else but accidentally left one of the three break
statements from the switch behind, skipping the clang_disposeString() call
for replacements (and the rest of the loop too, which apparently doesn't make
a differences for the test cases we have).

r96685: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100215/027754.html

This too might possibly the last leak in clang (PR19521).

llvm-svn: 208483
This commit is contained in:
Nico Weber 2014-05-10 23:56:43 +00:00
parent ef316ee8df
commit 3fddae75c7
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
clang/tools/c-index-test/c-index-test.c
View File

@ -977,7 +977,6 @@ void PrintDiagnostic(CXDiagnostic Diagnostic) {
PrintExtent(out, start_line, start_column, end_line, end_column); PrintExtent(out, start_line, start_column, end_line, end_column);
fprintf(out, " with \"%s\"\n", clang_getCString(insertion_text)); fprintf(out, " with \"%s\"\n", clang_getCString(insertion_text));
} }
break;
} }
clang_disposeString(insertion_text); clang_disposeString(insertion_text);
} }