[CUDA] Mark device functions as nounwind.

Summary:
This prevents clang from emitting 'invoke's and catch statements.

Things previously mostly worked thanks to TryToMarkNoThrow() in
CodeGenFunction.  But this is not a proper IPO, and it doesn't properly
handle cases like mutual recursion.

Fixes bug 30593.

Reviewers: tra

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D25166

llvm-svn: 283272
This commit is contained in:
Justin Lebar 2016-10-04 23:41:49 +00:00
parent 49e7614efb
commit 3e6449b4f4
5 changed files with 51 additions and 5 deletions

View File

@ -1814,6 +1814,9 @@ void CodeGenModule::ConstructAttributeList(
// them). LLVM will remove this attribute where it safely can.
FuncAttrs.addAttribute(llvm::Attribute::Convergent);
// Exceptions aren't supported in CUDA device code.
FuncAttrs.addAttribute(llvm::Attribute::NoUnwind);
// Respect -fcuda-flush-denormals-to-zero.
if (getLangOpts().CUDADeviceFlushDenormalsToZero)
FuncAttrs.addAttribute("nvptx-f32ftz", "true");

View File

@ -698,6 +698,10 @@ llvm::BasicBlock *CodeGenFunction::getInvokeDestImpl() {
return nullptr;
}
// CUDA device code doesn't have exceptions.
if (LO.CUDA && LO.CUDAIsDevice)
return nullptr;
// Check the innermost scope for a cached landing pad. If this is
// a non-EH cleanup, we'll check enclosing scopes in EmitLandingPad.
llvm::BasicBlock *LP = EHStack.begin()->getCachedLandingPad();

View File

@ -36,8 +36,8 @@ __host__ __device__ void bar() {
// DEVICE: attributes [[BAZ_ATTR]] = {
// DEVICE-SAME: convergent
// DEVICE-SAME: }
// DEVICE: attributes [[CALL_ATTR]] = { convergent }
// DEVICE: attributes [[ASM_ATTR]] = { convergent
// DEVICE-DAG: attributes [[CALL_ATTR]] = { convergent
// DEVICE-DAG: attributes [[ASM_ATTR]] = { convergent
// HOST: declare void @_Z3bazv() [[BAZ_ATTR:#[0-9]+]]
// HOST: attributes [[BAZ_ATTR]] = {

View File

@ -182,9 +182,9 @@ __device__ void df() {
df(); // CHECK: call void @_Z2dfv()
// Verify that we only call non-empty destructors
// CHECK-NEXT: call void @_ZN8T_FA_NEDD1Ev(%struct.T_FA_NED* %t_fa_ned) #6
// CHECK-NEXT: call void @_ZN7T_F_NEDD1Ev(%struct.T_F_NED* %t_f_ned) #6
// CHECK-NEXT: call void @_ZN7T_B_NEDD1Ev(%struct.T_B_NED* %t_b_ned) #6
// CHECK-NEXT: call void @_ZN8T_FA_NEDD1Ev(%struct.T_FA_NED* %t_fa_ned)
// CHECK-NEXT: call void @_ZN7T_F_NEDD1Ev(%struct.T_F_NED* %t_f_ned)
// CHECK-NEXT: call void @_ZN7T_B_NEDD1Ev(%struct.T_B_NED* %t_b_ned)
// CHECK-NEXT: call void @_ZN2VDD1Ev(%struct.VD* %vd)
// CHECK-NEXT: call void @_ZN3NEDD1Ev(%struct.NED* %ned)
// CHECK-NEXT: call void @_ZN2UDD1Ev(%struct.UD* %ud)

View File

@ -0,0 +1,39 @@
// RUN: %clang_cc1 -std=c++11 -fcxx-exceptions -fexceptions -fcuda-is-device \
// RUN: -triple nvptx-nvidia-cuda -emit-llvm -disable-llvm-passes -o - %s | \
// RUN FileCheck -check-prefix DEVICE %s
// RUN: %clang_cc1 -std=c++11 -fcxx-exceptions -fexceptions \
// RUN: -triple x86_64-unknown-linux-gnu -emit-llvm -disable-llvm-passes -o - %s | \
// RUN: FileCheck -check-prefix HOST %s
#include "Inputs/cuda.h"
__host__ __device__ void f();
// HOST: define void @_Z7host_fnv() [[HOST_ATTR:#[0-9]+]]
void host_fn() { f(); }
// DEVICE: define void @_Z3foov() [[DEVICE_ATTR:#[0-9]+]]
__device__ void foo() {
// DEVICE: call void @_Z1fv
f();
}
// DEVICE: define void @_Z12foo_noexceptv() [[DEVICE_ATTR:#[0-9]+]]
__device__ void foo_noexcept() noexcept {
// DEVICE: call void @_Z1fv
f();
}
// This is nounwind only on the device side.
// CHECK: define void @_Z3foov() [[DEVICE_ATTR:#[0-9]+]]
__host__ __device__ void bar() { f(); }
// DEVICE: define void @_Z3bazv() [[DEVICE_ATTR:#[0-9]+]]
__global__ void baz() { f(); }
// DEVICE: attributes [[DEVICE_ATTR]] = {
// DEVICE-SAME: nounwind
// HOST: attributes [[HOST_ATTR]] = {
// HOST-NOT: nounwind
// HOST-SAME: }