replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Rename clang.modules-cache-path to symbols.clang-modules-cache-path 

I want to extend the properties on ModuleList to also contain other
more general settings and renaming the settings category to symbols
seems to be the least bad of choices.

llvm-svn: 327193
This commit is contained in:
Adrian Prantl 2018-03-10 01:11:25 +00:00
parent 56e5a2e13e
commit 3cd29bcfe2
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lldb/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangModulesCache.py
View File

@ -32,7 +32,7 @@ class ObjCModulesTestCase(TestBase):
shutil.rmtree(mod_cache)
self.assertFalse(os.path.isdir(mod_cache),
"module cache should not exist")
self.runCmd('settings set clang.modules-cache-path "%s"' % mod_cache)
self.runCmd('settings set symbols.clang-modules-cache-path "%s"' % mod_cache)
self.runCmd('settings set target.clang-module-search-paths "%s"'
% self.getSourceDir())
(target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(

2
lldb/packages/Python/lldbsuite/test/lldbtest.py
View File

@ -1921,7 +1921,7 @@ class TestBase(Base):
if self.child:
assert(self.getDebugInfo() == 'default')
mod_cache = os.path.join(self.getBuildDir(), "module-cache")
self.runCmd('settings set clang.modules-cache-path "%s"'
self.runCmd('settings set symbols.clang-modules-cache-path "%s"'
% mod_cache)

4
lldb/source/Core/Debugger.cpp
View File

@ -776,8 +776,8 @@ Debugger::Debugger(lldb::LogOutputCallback log_callback, void *baton)
ConstString("platform"), ConstString("Platform settings."), true,
Platform::GetGlobalPlatformProperties()->GetValueProperties());
m_collection_sp->AppendProperty(
ConstString("clang"), ConstString("Settings specific to Clang."), true,
ModuleList::GetGlobalModuleListProperties().GetValueProperties());
ConstString("symbols"), ConstString("Symbol lookup and cache settings."),
true, ModuleList::GetGlobalModuleListProperties().GetValueProperties());
if (m_command_interpreter_ap) {
m_collection_sp->AppendProperty(
ConstString("interpreter"),

4
lldb/source/Core/ModuleList.cpp
View File

@ -67,7 +67,7 @@ using namespace lldb_private;
namespace {
PropertyDefinition g_properties[] = {
{"modules-cache-path", OptionValue::eTypeFileSpec, true, 0, nullptr,
{"clang-modules-cache-path", OptionValue::eTypeFileSpec, true, 0, nullptr,
nullptr,
"The path to the clang modules cache directory (-fmodules-cache-path)."},
{nullptr, OptionValue::eTypeInvalid, false, 0, nullptr, nullptr, nullptr}};
@ -77,7 +77,7 @@ enum { ePropertyClangModulesCachePath };
} // namespace
ModuleListProperties::ModuleListProperties() {
m_collection_sp.reset(new OptionValueProperties(ConstString("clang")));
m_collection_sp.reset(new OptionValueProperties(ConstString("symbols")));
m_collection_sp->Initialize(g_properties);
llvm::SmallString<128> path;