replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

We should not generate __weak write barrier on indirect reference 

of a pointer to object; This patch does this odd behavior according to
gcc.

llvm-svn: 65334
This commit is contained in:
Fariborz Jahanian 2009-02-23 18:59:50 +00:00
parent a94e52c687
commit 392124c78e
2 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/lib/AST/Expr.cpp
View File

@ -753,6 +753,8 @@ bool Expr::isOBJCGCCandidate() const {
return false;
case ObjCIvarRefExprClass:
return true;
case Expr::UnaryOperatorClass:
return cast<UnaryOperator>(this)->getSubExpr()->isOBJCGCCandidate();
case ParenExprClass:
return cast<ParenExpr>(this)->getSubExpr()->isOBJCGCCandidate();
case ImplicitCastExprClass:

15
clang/lib/CodeGen/CGExpr.cpp
View File

@ -669,10 +669,19 @@ LValue CodeGenFunction::EmitUnaryOpLValue(const UnaryOperator *E) {
case UnaryOperator::Deref:
{
QualType T = E->getSubExpr()->getType()->getAsPointerType()->getPointeeType();
return LValue::MakeAddr(EmitScalarExpr(E->getSubExpr()),
ExprTy->getAsPointerType()->getPointeeType()
LValue LV = LValue::MakeAddr(EmitScalarExpr(E->getSubExpr()),
ExprTy->getAsPointerType()->getPointeeType()
.getCVRQualifiers(),
getContext().getObjCGCAttrKind(T));
getContext().getObjCGCAttrKind(T));
// We should not generate __weak write barrier on indirect reference
// of a pointer to object; as in void foo (__weak id *param); *param = 0;
// But, we continue to generate __strong write barrier on indirect write
// into a pointer to object.
if (getContext().getLangOptions().ObjC1 &&
getContext().getLangOptions().getGCMode() != LangOptions::NonGC &&
LV.isObjCWeak())
LValue::SetObjCNonGC(LV, !E->isOBJCGCCandidate());
return LV;
}
case UnaryOperator::Real:
case UnaryOperator::Imag: