replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make GlobalValue alignment consistent with load, store, and alloca 

alignment, fixing silent truncation of alignment values.

llvm-svn: 109653
This commit is contained in:
Dan Gohman 2010-07-28 20:56:48 +00:00
parent f2234fbe70
commit 390914cbe8
3 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
llvm/include/llvm/GlobalValue.h
View File

@ -74,11 +74,10 @@ public:
removeDeadConstantUsers(); // remove any dead constants using this.
}
unsigned getAlignment() const { return Alignment; }
void setAlignment(unsigned Align) {
assert((Align & (Align-1)) == 0 && "Alignment is not a power of 2!");
Alignment = Align;
unsigned getAlignment() const {
return (1u << Alignment) >> 1;
}
void setAlignment(unsigned Align);
VisibilityTypes getVisibility() const { return VisibilityTypes(Visibility); }
bool hasDefaultVisibility() const { return Visibility == DefaultVisibility; }

9
llvm/lib/VMCore/Globals.cpp
View File

@ -102,7 +102,14 @@ void GlobalValue::copyAttributesFrom(const GlobalValue *Src) {
setVisibility(Src->getVisibility());
}
void GlobalValue::setAlignment(unsigned Align) {
assert((Align & (Align-1)) == 0 && "Alignment is not a power of 2!");
assert(Align <= MaximumAlignment &&
"Alignment is greater than MaximumAlignment!");
Alignment = Log2_32(Align) + 1;
assert(getAlignment() == Align && "Alignment representation error!");
}
//===----------------------------------------------------------------------===//
// GlobalVariable Implementation
//===----------------------------------------------------------------------===//

2
llvm/test/Assembler/align-inst.ll
View File

@ -1,5 +1,7 @@
; RUN: llvm-as %s -o /dev/null
@A = global i1 0, align 536870912
define void @foo() {
%p = alloca i1, align 536870912
load i1* %p, align 536870912