replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix a bunch of signed/unsigned comparison warnings, stop evaluating "getsize" every time through the loop. 

llvm-svn: 113433
This commit is contained in:
Chris Lattner 2010-09-08 22:55:31 +00:00
parent 30ee4ef308
commit 37c1b43144
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lldb/source/Commands/CommandObjectProcess.cpp
View File

@ -174,8 +174,8 @@ public:
if (run_args_value.GetSize() > 0) if (run_args_value.GetSize() > 0)
{ {
run_args = new Args; run_args = new Args;
for (int i = 0; i < run_args_value.GetSize(); ++i) for (unsigned i = 0, e = run_args_value.GetSize(); i != e; ++i)
run_args->AppendArgument (run_args_value.GetStringAtIndex (i)); run_args->AppendArgument(run_args_value.GetStringAtIndex(i));
} }
Args *environment = NULL; Args *environment = NULL;
@ -185,7 +185,7 @@ public:
if (env_vars_value.GetSize() > 0) if (env_vars_value.GetSize() > 0)
{ {
environment = new Args; environment = new Args;
for (int i = 0; i < env_vars_value.GetSize(); ++i) for (unsigned i = 0, e = env_vars_value.GetSize(); i != e; ++i)
environment->AppendArgument (env_vars_value.GetStringAtIndex (i)); environment->AppendArgument (env_vars_value.GetStringAtIndex (i));
} }

2
lldb/source/Commands/CommandObjectSettings.cpp
View File

@ -308,7 +308,7 @@ CommandObjectSettingsShow::Execute (CommandInterpreter &interpreter,
else else
{ {
result.AppendMessageWithFormat ("%s%s:\n", variable_name, type_name); result.AppendMessageWithFormat ("%s%s:\n", variable_name, type_name);
for (int i = 0; i < value.GetSize(); ++i) for (unsigned i = 0, e = value.GetSize(); i != e; ++i)
{ {
result.AppendMessageWithFormat (" [%d]: '%s'\n", i, value.GetStringAtIndex (i)); result.AppendMessageWithFormat (" [%d]: '%s'\n", i, value.GetStringAtIndex (i));
} }

6
lldb/source/Commands/CommandObjectSource.cpp
View File

@ -283,7 +283,7 @@ public:
if (m_options.m_modules.size() > 0) if (m_options.m_modules.size() > 0)
{ {
ModuleList matching_modules; ModuleList matching_modules;
for (int i = 0; i < m_options.m_modules.size(); i++) for (unsigned i = 0, e = m_options.m_modules.size(); i != e; i++)
{ {
FileSpec module_spec(m_options.m_modules[i].c_str()); FileSpec module_spec(m_options.m_modules[i].c_str());
if (module_spec) if (module_spec)
@ -457,7 +457,7 @@ public:
if (m_options.m_modules.size() > 0) if (m_options.m_modules.size() > 0)
{ {
ModuleList matching_modules; ModuleList matching_modules;
for (int i = 0; i < m_options.m_modules.size(); i++) for (unsigned i = 0, e = m_options.m_modules.size(); i != e; i++)
{ {
FileSpec module_spec(m_options.m_modules[i].c_str()); FileSpec module_spec(m_options.m_modules[i].c_str());
if (module_spec) if (module_spec)
@ -495,7 +495,7 @@ public:
bool got_multiple = false; bool got_multiple = false;
FileSpec *test_cu_spec = NULL; FileSpec *test_cu_spec = NULL;
for (int i = 0; i < num_matches; i++) for (unsigned i = 0; i < num_matches; i++)
{ {
sc_list.GetContextAtIndex(i, sc); sc_list.GetContextAtIndex(i, sc);
if (sc.comp_unit) if (sc.comp_unit)