From 3548eaf896f523845c1462f8744a4e5fb55f0697 Mon Sep 17 00:00:00 2001 From: Danil Malyshev Date: Thu, 29 Mar 2012 21:46:18 +0000 Subject: [PATCH] Re-factored RuntimeDyld. Added ExecutionEngine/MCJIT tests. llvm-svn: 153694 --- .../llvm/ExecutionEngine/RuntimeDyld.h | 11 - .../MCJIT/MCJITMemoryManager.h | 38 +- .../RuntimeDyld/RuntimeDyld.cpp | 295 ++++++++- .../RuntimeDyld/RuntimeDyldELF.cpp | 405 +++++------- .../RuntimeDyld/RuntimeDyldELF.h | 168 +---- .../RuntimeDyld/RuntimeDyldImpl.h | 168 ++++- .../RuntimeDyld/RuntimeDyldMachO.cpp | 623 +++--------------- .../RuntimeDyld/RuntimeDyldMachO.h | 86 +-- llvm/test/CMakeLists.txt | 2 + .../MCJIT/2002-12-16-ArgTest.ll | 37 ++ .../MCJIT/2003-01-04-ArgumentBug.ll | 13 + .../MCJIT/2003-01-04-LoopTest.ll | 20 + .../MCJIT/2003-01-04-PhiTest.ll | 12 + .../MCJIT/2003-01-09-SARTest.ll | 11 + .../ExecutionEngine/MCJIT/2003-01-10-FUCOM.ll | 10 + .../MCJIT/2003-01-15-AlignmentTest.ll | 17 + .../MCJIT/2003-05-06-LivenessClobber.ll | 19 + .../MCJIT/2003-05-07-ArgumentTest.ll | 11 + .../MCJIT/2003-05-11-PHIRegAllocBug.ll | 15 + .../MCJIT/2003-06-04-bzip2-bug.ll | 19 + .../MCJIT/2003-06-05-PHIBug.ll | 17 + .../MCJIT/2003-08-15-AllocaAssertion.ll | 11 + .../MCJIT/2003-08-21-EnvironmentTest.ll | 21 + .../2003-08-23-RegisterAllocatePhysReg.ll | 34 + ...8-PHINode-ConstantExpr-CondCode-Failure.ll | 23 + .../MCJIT/2005-12-02-TailCallBug.ll | 22 + .../MCJIT/2007-12-10-APIntLoadStore.ll | 19 + .../MCJIT/2008-06-05-APInt-OverAShr.ll | 59 ++ .../MCJIT/2010-01-15-UndefValue.ll | 8 + llvm/test/ExecutionEngine/MCJIT/fpbitcast.ll | 20 + llvm/test/ExecutionEngine/MCJIT/hello.ll | 11 + llvm/test/ExecutionEngine/MCJIT/hello2.ll | 17 + llvm/test/ExecutionEngine/MCJIT/lit.local.cfg | 17 + .../ExecutionEngine/MCJIT/simplesttest.ll | 6 + llvm/test/ExecutionEngine/MCJIT/simpletest.ll | 11 + llvm/test/ExecutionEngine/MCJIT/test-arith.ll | 34 + .../test/ExecutionEngine/MCJIT/test-branch.ll | 12 + .../MCJIT/test-call-no-external-funcs.ll | 14 + llvm/test/ExecutionEngine/MCJIT/test-call.ll | 21 + llvm/test/ExecutionEngine/MCJIT/test-cast.ll | 109 +++ .../MCJIT/test-constantexpr.ll | 12 + .../MCJIT/test-fp-no-external-funcs.ll | 21 + llvm/test/ExecutionEngine/MCJIT/test-fp.ll | 23 + .../MCJIT/test-global-init-nonzero.ll | 34 + .../ExecutionEngine/MCJIT/test-loadstore.ll | 31 + llvm/test/ExecutionEngine/MCJIT/test-local.ll | 34 + .../ExecutionEngine/MCJIT/test-logical.ll | 18 + llvm/test/ExecutionEngine/MCJIT/test-loop.ll | 14 + llvm/test/ExecutionEngine/MCJIT/test-phi.ll | 34 + llvm/test/ExecutionEngine/MCJIT/test-ret.ll | 46 ++ .../test/ExecutionEngine/MCJIT/test-return.ll | 8 + .../ExecutionEngine/MCJIT/test-setcond-fp.ll | 24 + .../ExecutionEngine/MCJIT/test-setcond-int.ll | 69 ++ llvm/test/ExecutionEngine/MCJIT/test-shift.ll | 32 + llvm/test/Makefile | 2 + llvm/test/lit.site.cfg.in | 1 + llvm/tools/llvm-rtdyld/llvm-rtdyld.cpp | 16 - 57 files changed, 1820 insertions(+), 1065 deletions(-) create mode 100644 llvm/test/ExecutionEngine/MCJIT/2002-12-16-ArgTest.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2003-01-04-ArgumentBug.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2003-01-04-LoopTest.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2003-01-04-PhiTest.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2003-01-09-SARTest.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2003-01-10-FUCOM.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2003-01-15-AlignmentTest.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2003-05-06-LivenessClobber.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2003-05-07-ArgumentTest.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2003-05-11-PHIRegAllocBug.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2003-06-04-bzip2-bug.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2003-06-05-PHIBug.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2003-08-15-AllocaAssertion.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2003-08-21-EnvironmentTest.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2003-08-23-RegisterAllocatePhysReg.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2003-10-18-PHINode-ConstantExpr-CondCode-Failure.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2005-12-02-TailCallBug.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2007-12-10-APIntLoadStore.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2008-06-05-APInt-OverAShr.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/2010-01-15-UndefValue.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/fpbitcast.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/hello.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/hello2.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/lit.local.cfg create mode 100644 llvm/test/ExecutionEngine/MCJIT/simplesttest.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/simpletest.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-arith.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-branch.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-call-no-external-funcs.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-call.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-cast.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-constantexpr.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-fp-no-external-funcs.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-fp.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-global-init-nonzero.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-loadstore.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-local.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-logical.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-loop.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-phi.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-ret.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-return.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-setcond-fp.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-setcond-int.ll create mode 100644 llvm/test/ExecutionEngine/MCJIT/test-shift.ll diff --git a/llvm/include/llvm/ExecutionEngine/RuntimeDyld.h b/llvm/include/llvm/ExecutionEngine/RuntimeDyld.h index 81acc0867361..54c28f3ec142 100644 --- a/llvm/include/llvm/ExecutionEngine/RuntimeDyld.h +++ b/llvm/include/llvm/ExecutionEngine/RuntimeDyld.h @@ -45,17 +45,6 @@ public: virtual uint8_t *allocateDataSection(uintptr_t Size, unsigned Alignment, unsigned SectionID) = 0; - // Allocate ActualSize bytes, or more, for the named function. Return - // a pointer to the allocated memory and update Size to reflect how much - // memory was acutally allocated. - virtual uint8_t *startFunctionBody(const char *Name, uintptr_t &Size) = 0; - - // Mark the end of the function, including how much of the allocated - // memory was actually used. - virtual void endFunctionBody(const char *Name, uint8_t *FunctionStart, - uint8_t *FunctionEnd) = 0; - - virtual void *getPointerToNamedFunction(const std::string &Name, bool AbortOnFailure = true) = 0; }; diff --git a/llvm/lib/ExecutionEngine/MCJIT/MCJITMemoryManager.h b/llvm/lib/ExecutionEngine/MCJIT/MCJITMemoryManager.h index 118b0d42ee84..a68949aa41c8 100644 --- a/llvm/lib/ExecutionEngine/MCJIT/MCJITMemoryManager.h +++ b/llvm/lib/ExecutionEngine/MCJIT/MCJITMemoryManager.h @@ -34,12 +34,12 @@ public: uint8_t *allocateDataSection(uintptr_t Size, unsigned Alignment, unsigned SectionID) { - return JMM->allocateDataSection(Size, Alignment, SectionID); + return JMM->allocateSpace(Size, Alignment); } uint8_t *allocateCodeSection(uintptr_t Size, unsigned Alignment, unsigned SectionID) { - return JMM->allocateCodeSection(Size, Alignment, SectionID); + return JMM->allocateSpace(Size, Alignment); } virtual void *getPointerToNamedFunction(const std::string &Name, @@ -47,40 +47,6 @@ public: return JMM->getPointerToNamedFunction(Name, AbortOnFailure); } - // Allocate ActualSize bytes, or more, for the named function. Return - // a pointer to the allocated memory and update Size to reflect how much - // memory was acutally allocated. - uint8_t *startFunctionBody(const char *Name, uintptr_t &Size) { - // FIXME: This should really reference the MCAsmInfo to get the global - // prefix. - if (Name[0] == '_') ++Name; - Function *F = M->getFunction(Name); - // Some ObjC names have a prefixed \01 in the IR. If we failed to find - // the symbol and it's of the ObjC conventions (starts with "-" or - // "+"), try prepending a \01 and see if we can find it that way. - if (!F && (Name[0] == '-' || Name[0] == '+')) - F = M->getFunction((Twine("\1") + Name).str()); - assert(F && "No matching function in JIT IR Module!"); - return JMM->startFunctionBody(F, Size); - } - - // Mark the end of the function, including how much of the allocated - // memory was actually used. - void endFunctionBody(const char *Name, uint8_t *FunctionStart, - uint8_t *FunctionEnd) { - // FIXME: This should really reference the MCAsmInfo to get the global - // prefix. - if (Name[0] == '_') ++Name; - Function *F = M->getFunction(Name); - // Some ObjC names have a prefixed \01 in the IR. If we failed to find - // the symbol and it's of the ObjC conventions (starts with "-" or - // "+"), try prepending a \01 and see if we can find it that way. - if (!F && (Name[0] == '-' || Name[0] == '+')) - F = M->getFunction((Twine("\1") + Name).str()); - assert(F && "No matching function in JIT IR Module!"); - JMM->endFunctionBody(F, FunctionStart, FunctionEnd); - } - }; } // End llvm namespace diff --git a/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp b/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp index 2896c2d556c5..7a2b8586119b 100644 --- a/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp +++ b/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp @@ -26,45 +26,290 @@ RuntimeDyldImpl::~RuntimeDyldImpl() {} namespace llvm { -void RuntimeDyldImpl::extractFunction(StringRef Name, uint8_t *StartAddress, - uint8_t *EndAddress) { - // FIXME: DEPRECATED in favor of by-section allocation. - // Allocate memory for the function via the memory manager. - uintptr_t Size = EndAddress - StartAddress + 1; - uintptr_t AllocSize = Size; - uint8_t *Mem = MemMgr->startFunctionBody(Name.data(), AllocSize); - assert(Size >= (uint64_t)(EndAddress - StartAddress + 1) && - "Memory manager failed to allocate enough memory!"); - // Copy the function payload into the memory block. - memcpy(Mem, StartAddress, Size); - MemMgr->endFunctionBody(Name.data(), Mem, Mem + Size); - // Remember where we put it. - unsigned SectionID = Sections.size(); - Sections.push_back(sys::MemoryBlock(Mem, Size)); +namespace { + // Helper for extensive error checking in debug builds. + error_code Check(error_code Err) { + if (Err) { + report_fatal_error(Err.message()); + } + return Err; + } +} // end anonymous namespace - // Default the assigned address for this symbol to wherever this - // allocated it. - SymbolTable[Name] = SymbolLoc(SectionID, 0); - DEBUG(dbgs() << " allocated to [" << Mem << ", " << Mem + Size << "]\n"); -} // Resolve the relocations for all symbols we currently know about. void RuntimeDyldImpl::resolveRelocations() { + // First, resolve relocations assotiated with external symbols. + resolveSymbols(); + // Just iterate over the sections we have and resolve all the relocations // in them. Gross overkill, but it gets the job done. for (int i = 0, e = Sections.size(); i != e; ++i) { - reassignSectionAddress(i, SectionLoadAddress[i]); + reassignSectionAddress(i, Sections[i].LoadAddress); } } void RuntimeDyldImpl::mapSectionAddress(void *LocalAddress, uint64_t TargetAddress) { - assert(SectionLocalMemToID.count(LocalAddress) && - "Attempting to remap address of unknown section!"); - unsigned SectionID = SectionLocalMemToID[LocalAddress]; - reassignSectionAddress(SectionID, TargetAddress); + for (unsigned i = 0, e = Sections.size(); i != e; ++i) { + if (Sections[i].Address == LocalAddress) { + reassignSectionAddress(i, TargetAddress); + return; + } + } + llvm_unreachable("Attempting to remap address of unknown section!"); } +bool RuntimeDyldImpl::loadObject(const MemoryBuffer *InputBuffer) { + // FIXME: ObjectFile don't modify MemoryBuffer. + // It should use const MemoryBuffer as parameter. + ObjectFile *obj + = ObjectFile::createObjectFile(const_cast(InputBuffer)); + + Arch = (Triple::ArchType)obj->getArch(); + + LocalSymbolMap LocalSymbols; // Functions and data symbols from the + // object file. + ObjSectionToIDMap LocalSections; // Used sections from the object file + + error_code err; + // Parse symbols + DEBUG(dbgs() << "Parse symbols:\n"); + for (symbol_iterator i = obj->begin_symbols(), e = obj->end_symbols(); + i != e; i.increment(err)) { + Check(err); + object::SymbolRef::Type SymType; + StringRef Name; + Check(i->getType(SymType)); + Check(i->getName(Name)); + + if (SymType == object::SymbolRef::ST_Function || + SymType == object::SymbolRef::ST_Data) { + uint64_t FileOffset; + uint32_t flags; + StringRef sData; + section_iterator si = obj->end_sections(); + Check(i->getFileOffset(FileOffset)); + Check(i->getFlags(flags)); + Check(i->getSection(si)); + if (si == obj->end_sections()) continue; + Check(si->getContents(sData)); + const uint8_t* SymPtr = (const uint8_t*)InputBuffer->getBufferStart() + + (uintptr_t)FileOffset; + uintptr_t SectOffset = (uintptr_t)(SymPtr - (const uint8_t*)sData.begin()); + unsigned SectionID + = findOrEmitSection(*si, + SymType == object::SymbolRef::ST_Function, + LocalSections); + bool isGlobal = flags & SymbolRef::SF_Global; + LocalSymbols[Name.data()] = SymbolLoc(SectionID, SectOffset); + DEBUG(dbgs() << "\tFileOffset: " << format("%p", (uintptr_t)FileOffset) + << " flags: " << flags + << " SID: " << SectionID + << " Offset: " << format("%p", SectOffset)); + if (isGlobal) + SymbolTable[Name] = SymbolLoc(SectionID, SectOffset); + } + DEBUG(dbgs() << "\tType: " << SymType << " Name: " << Name << "\n"); + } + + // Parse and proccess relocations + DEBUG(dbgs() << "Parse relocations:\n"); + for (section_iterator si = obj->begin_sections(), + se = obj->end_sections(); si != se; si.increment(err)) { + Check(err); + bool isFirstRelocation = true; + unsigned SectionID = 0; + StubMap Stubs; + + for (relocation_iterator i = si->begin_relocations(), + e = si->end_relocations(); i != e; i.increment(err)) { + Check(err); + + // If it's first relocation in this section, find its SectionID + if (isFirstRelocation) { + SectionID = findOrEmitSection(*si, true, LocalSections); + DEBUG(dbgs() << "\tSectionID: " << SectionID << "\n"); + isFirstRelocation = false; + } + + ObjRelocationInfo RI; + RI.SectionID = SectionID; + Check(i->getAdditionalInfo(RI.AdditionalInfo)); + Check(i->getOffset(RI.Offset)); + Check(i->getSymbol(RI.Symbol)); + Check(i->getType(RI.Type)); + + DEBUG(dbgs() << "\t\tAddend: " << RI.AdditionalInfo + << " Offset: " << format("%p", (uintptr_t)RI.Offset) + << " Type: " << (uint32_t)(RI.Type & 0xffffffffL) + << "\n"); + processRelocationRef(RI, *obj, LocalSections, LocalSymbols, Stubs); + } + } + return false; +} + +unsigned RuntimeDyldImpl::emitSection(const SectionRef &Section, + bool IsCode) { + + unsigned StubBufSize = 0, + StubSize = getMaxStubSize(); + error_code err; + if (StubSize > 0) { + for (relocation_iterator i = Section.begin_relocations(), + e = Section.end_relocations(); i != e; i.increment(err)) + StubBufSize += StubSize; + } + StringRef data; + uint64_t Alignment64; + Check(Section.getContents(data)); + Check(Section.getAlignment(Alignment64)); + + unsigned Alignment = (unsigned)Alignment64 & 0xffffffffL; + unsigned DataSize = data.size(); + unsigned Allocate = DataSize + StubBufSize; + unsigned SectionID = Sections.size(); + const char *pData = data.data(); + uint8_t *Addr = IsCode + ? MemMgr->allocateCodeSection(Allocate, Alignment, SectionID) + : MemMgr->allocateDataSection(Allocate, Alignment, SectionID); + + memcpy(Addr, pData, DataSize); + DEBUG(dbgs() << "emitSection SectionID: " << SectionID + << " obj addr: " << format("%p", pData) + << " new addr: " << format("%p", Addr) + << " DataSize: " << DataSize + << " StubBufSize: " << StubBufSize + << " Allocate: " << Allocate + << "\n"); + Sections.push_back(SectionEntry(Addr, Allocate, DataSize,(uintptr_t)pData)); + return SectionID; +} + +unsigned RuntimeDyldImpl::findOrEmitSection(const SectionRef &Section, + bool IsCode, + ObjSectionToIDMap &LocalSections) { + + unsigned SectionID = 0; + ObjSectionToIDMap::iterator i = LocalSections.find(Section); + if (i != LocalSections.end()) + SectionID = i->second; + else { + SectionID = emitSection(Section, IsCode); + LocalSections[Section] = SectionID; + } + return SectionID; +} + +void RuntimeDyldImpl::AddRelocation(const RelocationValueRef &Value, + unsigned SectionID, uintptr_t Offset, + uint32_t RelType) { + DEBUG(dbgs() << "AddRelocation SymNamePtr: " << format("%p", Value.SymbolName) + << " SID: " << Value.SectionID + << " Addend: " << format("%p", Value.Addend) + << " Offset: " << format("%p", Offset) + << " RelType: " << format("%x", RelType) + << "\n"); + + if (Value.SymbolName == 0) { + Relocations[Value.SectionID].push_back(RelocationEntry( + SectionID, + Offset, + RelType, + Value.Addend)); + } else + SymbolRelocations[Value.SymbolName].push_back(RelocationEntry( + SectionID, + Offset, + RelType, + Value.Addend)); +} + +uint8_t *RuntimeDyldImpl::createStubFunction(uint8_t *Addr) { + // TODO: There is only ARM far stub now. We should add the Thumb stub, + // and stubs for branches Thumb - ARM and ARM - Thumb. + if (Arch == Triple::arm) { + uint32_t *StubAddr = (uint32_t*)Addr; + *StubAddr = 0xe51ff004; // ldr pc,