support operator keywords used in Windows SDK

to support operator keywords used in Windows SDK, alter token type when 
seen in system headers

Hello, I submitted D33505 to address this problem, but the 
proposal was rejected as too big a hammer.
This change will allow clang to parse the WindowsSDK header <query.h> 
which uses the operator name "or" as a field name. Treat cpp operator 
keywords as ordinary identifiers inside the Microsoft headers, but 
treat them as usual in the user's program.

Original Submitter: Melanie Blower (mibintc)

Differential Revision: https://reviews.llvm.org/D33782

llvm-svn: 305087
This commit is contained in:
Erich Keane 2017-06-09 16:29:35 +00:00
parent 31ce4ec2fd
commit 33c3d8a916
4 changed files with 59 additions and 1 deletions

View File

@ -580,7 +580,11 @@ IdentifierInfo *Preprocessor::LookUpIdentifierInfo(Token &Identifier) const {
// Update the token info (identifier info and appropriate token kind).
Identifier.setIdentifierInfo(II);
Identifier.setKind(II->getTokenID());
if (getLangOpts().MSVCCompat && II->isCPlusPlusOperatorKeyword() &&
getSourceManager().isInSystemHeader(Identifier.getLocation()))
Identifier.setKind(clang::tok::identifier);
else
Identifier.setKind(II->getTokenID());
return II;
}

View File

@ -0,0 +1,16 @@
// RUN: %clang_cc1 \
// RUN: -fms-compatibility -x c++-cpp-output \
// RUN: -ffreestanding -fsyntax-only -Werror \
// RUN: %s -verify
// expected-no-diagnostics
# 1 "t.cpp"
# 1 "query.h" 1 3
// MS header <query.h> uses operator keyword as field name.
// Compile without syntax errors.
struct tagRESTRICTION
{
union _URes
{
int or; // Note use of cpp operator token
} res;
};

View File

@ -0,0 +1,27 @@
// RUN: %clang_cc1 \
// RUN: -fms-compatibility -x c++-cpp-output \
// RUN: -ffreestanding -fsyntax-only -Werror \
// RUN: %s -verify
# 1 "t.cpp"
# 1 "query.h" 1 3 4
// MS header <query.h> uses operator keyword as field name.
// Compile without syntax errors.
struct tagRESTRICTION
{
union _URes
{
int or; // Note use of cpp operator token
} res;
};
;
int aa ( int x)
{
// In system header code, treat operator keyword as identifier.
if ( // expected-note{{to match this '('}}
x>1 or x<0) return 1; // expected-error{{expected ')'}}
else return 0;
}

View File

@ -0,0 +1,11 @@
// RUN: %clang_cc1 -triple x86_64-pc-win32 -fms-compatibility \
// RUN: -ffreestanding -fsyntax-only -Werror %s -verify
// RUN: %clang_cc1 \
// RUN: -ffreestanding -fsyntax-only -Werror %s -verify
// expected-no-diagnostics
int bb ( int x)
{
// In user code, treat operator keyword as operator keyword.
if ( x>1 or x<0) return 1;
else return 0;
}