replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make debugserver quieter about memory read errors. 

<rdar://problem/10681220>

llvm-svn: 152438
This commit is contained in:
Jim Ingham 2012-03-09 21:09:42 +00:00
parent b7d1ca27bd
commit 329617a80a
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lldb/tools/debugserver/source/MacOSX/MachVMMemory.cpp
View File

@ -104,9 +104,7 @@ MachVMMemory::Read(task_t task, nub_addr_t address, void *data, nub_size_t data_
vm_offset_t vm_memory = NULL;
m_err = ::mach_vm_read (task, curr_addr, curr_size, &vm_memory, &curr_bytes_read);
// We end up being asked to read memory at 0x0 a lot without that being a real error, so that ends up just
// causing a lot of useless log spam. Only complain on failing reads if the address is not 0x0.
if (DNBLogCheckLogBit(LOG_MEMORY) || (m_err.Fail() && curr_addr != 0))
if (DNBLogCheckLogBit(LOG_MEMORY))
m_err.LogThreaded("::mach_vm_read ( task = 0x%4.4x, addr = 0x%8.8llx, size = %llu, data => %8.8p, dataCnt => %i )", task, (uint64_t)curr_addr, (uint64_t)curr_size, vm_memory, curr_bytes_read);
if (m_err.Success())