replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Tweak diagnostic text to indicate that __weak on a local variable is only allowed 

for ARC.  Fixes <rdar://problem/12407705>

llvm-svn: 164990
This commit is contained in:
Ted Kremenek 2012-10-02 05:36:02 +00:00
parent 5de91cc35f
commit 2f88c40ded
3 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clang/include/clang/Basic/DiagnosticSemaKinds.td
View File

@ -1744,7 +1744,8 @@ def warn_nsobject_attribute : Warning<
"__attribute ((NSObject)) may be put on a typedef only, "
"attribute is ignored">, InGroup<NSobjectAttribute>;
def warn_attribute_weak_on_local : Warning<
"__weak attribute cannot be specified on an automatic variable">,
"__weak attribute cannot be specified on an automatic variable when ARC "
"is not enabled">,
InGroup<IgnoredAttributes>;
def warn_weak_identifier_undeclared : Warning<
"weak identifier %0 never declared">;

4
clang/lib/Sema/SemaDecl.cpp
View File

@ -4578,8 +4578,10 @@ bool Sema::CheckVariableDeclaration(VarDecl *NewVD,
&& !NewVD->hasAttr<BlocksAttr>()) {
if (getLangOpts().getGC() != LangOptions::NonGC)
Diag(NewVD->getLocation(), diag::warn_gc_attribute_weak_on_local);
else
else {
assert(!getLangOpts().ObjCAutoRefCount);
Diag(NewVD->getLocation(), diag::warn_attribute_weak_on_local);
}
}
bool isVM = T->isVariablyModifiedType();

16
clang/test/SemaObjC/nonarc-weak.m Normal file
View File

@ -0,0 +1,16 @@
// RUN: %clang -fsyntax-only -Wunused-function %s > %t.nonarc 2>&1
// RUN: %clang -fsyntax-only -Wunused-function -fobjc-arc %s > %t.arc 2>&1
// RUN: FileCheck -input-file=%t.nonarc %s
// RUN: FileCheck -input-file=%t.arc -check-prefix=ARC %s
static void bar() {} // Intentionally unused.
void foo(id self) {
__weak id weakSelf = self;
}
// CHECK: 9:13: warning: __weak attribute cannot be specified on an automatic variable when ARC is not enabled
// CHECK: 6:13: warning: unused function 'bar'
// CHECK: 2 warnings generated
// ARC: 6:13: warning: unused function 'bar'
// ARC: 1 warning generated