replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix -fno-gnu-inline-asm doesn't catch file scope asm 

Summary:
FileScopeAsm should be treated the same as funcion level inline asm.
-fno-gnu-inline-asm should trigger an error if file scope asm is used.
I missed this case from r226340. This should not affect ms-extension
because it is not allowed in the file scope.

Reviewers: bob.wilson, rnk

Reviewed By: rnk

Subscribers: cfe-commits

Differential Revision: http://reviews.llvm.org/D9328

llvm-svn: 236044
This commit is contained in:
Steven Wu 2015-04-28 21:49:09 +00:00
parent 6d69e8c00b
commit 2baa53ace9
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clang/lib/Parse/Parser.cpp
View File

@ -1253,6 +1253,10 @@ ExprResult Parser::ParseSimpleAsm(SourceLocation *EndLoc) {
assert(Tok.is(tok::kw_asm) && "Not an asm!"); assert(Tok.is(tok::kw_asm) && "Not an asm!");
SourceLocation Loc = ConsumeToken(); SourceLocation Loc = ConsumeToken();
// Check if GNU-styple InlineAsm is disabled.
if (!getLangOpts().GNUAsm)
Diag(Loc, diag::err_gnu_inline_asm_disabled);
if (Tok.is(tok::kw_volatile)) { if (Tok.is(tok::kw_volatile)) {
// Remove from the end of 'asm' to the end of 'volatile'. // Remove from the end of 'asm' to the end of 'volatile'.
SourceRange RemovalRange(PP.getLocForEndOfToken(Loc), SourceRange RemovalRange(PP.getLocForEndOfToken(Loc),

1
clang/test/Parser/no-gnu-inline-asm.c
View File

@ -1,5 +1,6 @@
// RUN: %clang_cc1 %s -triple i686-apple-darwin -verify -fsyntax-only -fno-gnu-inline-asm // RUN: %clang_cc1 %s -triple i686-apple-darwin -verify -fsyntax-only -fno-gnu-inline-asm
asm ("INST r1, 0"); // expected-error {{GNU-style inline assembly is disabled}}
void f (void) { void f (void) {
long long foo = 0, bar; long long foo = 0, bar;
asm volatile("INST %0, %1" : "=r"(foo) : "r"(bar)); // expected-error {{GNU-style inline assembly is disabled}} asm volatile("INST %0, %1" : "=r"(foo) : "r"(bar)); // expected-error {{GNU-style inline assembly is disabled}}