diff --git a/llvm/include/llvm/TableGen/Record.h b/llvm/include/llvm/TableGen/Record.h index 9aaf121e64ba..8ba1992083fa 100644 --- a/llvm/include/llvm/TableGen/Record.h +++ b/llvm/include/llvm/TableGen/Record.h @@ -1200,7 +1200,7 @@ public: Init *getBit(unsigned Bit) const override; Init *resolveReferences(Resolver &R) const override; - Init *Fold() const; + Init *Fold(Record *CurRec) const; std::string getAsString() const override { return Rec->getAsString() + "." + FieldName->getValue().str(); diff --git a/llvm/lib/TableGen/Record.cpp b/llvm/lib/TableGen/Record.cpp index 333f45b7be91..866cda3152f0 100644 --- a/llvm/lib/TableGen/Record.cpp +++ b/llvm/lib/TableGen/Record.cpp @@ -1684,13 +1684,19 @@ Init *FieldInit::getBit(unsigned Bit) const { Init *FieldInit::resolveReferences(Resolver &R) const { Init *NewRec = Rec->resolveReferences(R); if (NewRec != Rec) - return FieldInit::get(NewRec, FieldName)->Fold(); + return FieldInit::get(NewRec, FieldName)->Fold(R.getCurrentRecord()); return const_cast(this); } -Init *FieldInit::Fold() const { +Init *FieldInit::Fold(Record *CurRec) const { if (DefInit *DI = dyn_cast(Rec)) { - Init *FieldVal = DI->getDef()->getValue(FieldName)->getValue(); + Record *Def = DI->getDef(); + if (Def == CurRec) + PrintFatalError(CurRec->getLoc(), + Twine("Attempting to access field '") + + FieldName->getAsUnquotedString() + "' of '" + + Rec->getAsString() + "' is a forbidden self-reference"); + Init *FieldVal = Def->getValue(FieldName)->getValue(); if (FieldVal->isComplete()) return FieldVal; } diff --git a/llvm/lib/TableGen/TGParser.cpp b/llvm/lib/TableGen/TGParser.cpp index 0c92cf749657..0eb75424db5c 100644 --- a/llvm/lib/TableGen/TGParser.cpp +++ b/llvm/lib/TableGen/TGParser.cpp @@ -1943,7 +1943,7 @@ Init *TGParser::ParseValue(Record *CurRec, RecTy *ItemType, IDParseMode Mode) { Result->getAsString() + "'"); return nullptr; } - Result = FieldInit::get(Result, FieldName)->Fold(); + Result = FieldInit::get(Result, FieldName)->Fold(CurRec); Lex.Lex(); // eat field name break; } diff --git a/llvm/test/TableGen/self-reference-recursion.td b/llvm/test/TableGen/self-reference-recursion.td new file mode 100644 index 000000000000..7eadfb7cf788 --- /dev/null +++ b/llvm/test/TableGen/self-reference-recursion.td @@ -0,0 +1,9 @@ +// RUN: not llvm-tblgen %s 2>&1 | FileCheck %s +// XFAIL: vg_leak + +class A { + int x = !cast(self).x; +} + +// CHECK: error: Attempting to access field 'x' of 'A0' is a forbidden self-reference +def A0 : A<"A0">;