replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[clang-tidy] Use simple string matching instead of Regex 

Instead of parsing and compiling the `llvm::Regex` each time, it's
faster to use basic string matching for filename prefix check.

Reviewed by: hokein

Differential Revision: https://reviews.llvm.org/D51360

llvm-svn: 341061
This commit is contained in:
Kirill Bobyrev 2018-08-30 12:42:19 +00:00
parent bf3bc7117e
commit 29925890d9
1 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h
View File

@ -6,9 +6,10 @@
// License. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
//
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
#include <algorithm>
namespace clang {
namespace ast_matchers {
@ -28,10 +29,9 @@ namespace ast_matchers {
///
/// Usable as: Matcher<Decl>, Matcher<Stmt>, Matcher<TypeLoc>,
/// Matcher<NestedNameSpecifierLoc>
AST_POLYMORPHIC_MATCHER(isInAbseilFile,
AST_POLYMORPHIC_SUPPORTED_TYPES(
Decl, Stmt, TypeLoc, NestedNameSpecifierLoc)) {
AST_POLYMORPHIC_MATCHER(
isInAbseilFile, AST_POLYMORPHIC_SUPPORTED_TYPES(Decl, Stmt, TypeLoc,
NestedNameSpecifierLoc)) {
auto &SourceManager = Finder->getASTContext().getSourceManager();
SourceLocation Loc = Node.getBeginLoc();
if (Loc.isInvalid())
@ -40,11 +40,21 @@ AST_POLYMORPHIC_MATCHER(isInAbseilFile,
SourceManager.getFileEntryForID(SourceManager.getFileID(Loc));
if (!FileEntry)
return false;
StringRef Filename = FileEntry->getName();
llvm::Regex RE(
"absl/(algorithm|base|container|debugging|memory|meta|numeric|strings|"
"synchronization|time|types|utility)");
return RE.match(Filename);
// Determine whether filepath contains "absl/[absl-library]" substring, where
// [absl-library] is AbseilLibraries list entry.
StringRef Path = FileEntry->getName();
const static llvm::SmallString<5> AbslPrefix("absl/");
size_t PrefixPosition = Path.find(AbslPrefix);
if (PrefixPosition == StringRef::npos)
return false;
Path = Path.drop_front(PrefixPosition + AbslPrefix.size());
static const char *AbseilLibraries[] = {
"algorithm", "base", "container", "debugging",
"memory", "meta", "numeric", "strings",
"synchronization", "time", "types", "utility"};
return std::any_of(
std::begin(AbseilLibraries), std::end(AbseilLibraries),
[&](const char *Library) { return Path.startswith(Library); });
}
} // namespace ast_matchers