replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

LTO: Remove unnecessary Windows support code. 

I empirically verified that open files can in fact be renamed on
Windows with sys::fs::rename, so remove the incorrect code and comment.

llvm-svn: 312683
This commit is contained in:
Peter Collingbourne 2017-09-07 00:55:00 +00:00
parent 3310888aec
commit 264d7c9021
1 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
llvm/lib/LTO/Caching.cpp
View File

@ -63,20 +63,6 @@ Expected<NativeObjectCache> lto::localCache(StringRef CacheDirectoryPath,
// Make sure the file is closed before committing it.
OS.reset();
#ifdef _WIN32
// Rename the file first on Windows because we cannot rename an open
// file on that platform using the sys::fs::rename function.
// FIXME: This code could race with the cache pruner, but it is unlikely
// that the cache pruner will choose to remove a newly created file.
// We should look at using the SetFileInformationByHandle function to
// rename the file while it is open.
if (auto EC = sys::fs::rename(TempFilename, EntryPath))
report_fatal_error(Twine("Failed to rename temporary file ") +
TempFilename + ": " + EC.message() + "\n");
ErrorOr<std::unique_ptr<MemoryBuffer>> MBOrErr =
MemoryBuffer::getFile(EntryPath);
#else
// Open the file first to avoid racing with a cache pruner.
ErrorOr<std::unique_ptr<MemoryBuffer>> MBOrErr =
MemoryBuffer::getFile(TempFilename);
@ -85,7 +71,6 @@ Expected<NativeObjectCache> lto::localCache(StringRef CacheDirectoryPath,
if (auto EC = sys::fs::rename(TempFilename, EntryPath))
report_fatal_error(Twine("Failed to rename temporary file ") +
TempFilename + ": " + EC.message() + "\n");
#endif
if (!MBOrErr)
report_fatal_error(Twine("Failed to open cache file ") + EntryPath +