replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Sema: delay the DLL exported member referencing 

An explicit template specialization can cause the implicit template
specialization of a type which inherits the attributes.  In such a case, we
would end up with a delayed template specialization for a dll exported type
which we would fail to reference.  This would trigger an assertion.

We now propagate the dll storage attributes through the inheritance
chain.  Only after having done so do we reference the delayed template
specializations.  This allows any implicit specializations which inherit dll
storage to also be referenced.

llvm-svn: 288570
This commit is contained in:
Saleem Abdulrasool 2016-12-03 01:57:47 +00:00
parent 584042981d
commit 25dbdfa0ac
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clang/lib/Sema/SemaTemplate.cpp
View File

@ -7687,7 +7687,6 @@ Sema::ActOnExplicitInstantiation(Scope *S,
assert(DelayedDllExportClasses.empty() &&
"delayed exports present at explicit instantiation");
checkClassLevelDLLAttribute(Def);
referenceDLLExportedClassMethods();
// Propagate attribute to base class templates.
for (auto &B : Def->bases()) {
@ -7695,6 +7694,8 @@ Sema::ActOnExplicitInstantiation(Scope *S,
B.getType()->getAsCXXRecordDecl()))
propagateDLLAttrToBaseClassTemplate(Def, A, BT, B.getLocStart());
}
referenceDLLExportedClassMethods();
}
}

18
clang/test/CodeGenCXX/windows-implicit-dllexport-template-specialization.cpp Normal file
View File

@ -0,0 +1,18 @@
// RUN: %clang_cc1 -std=c++11 -triple i686-windows -fdeclspec -emit-llvm %s -o - | FileCheck %s -check-prefix CHECK-MS
// RUN: %clang_cc1 -std=c++11 -triple i686-windows-itanium -fdeclspec -emit-llvm %s -o - | FileCheck %s -check-prefix CHECK-IA
template <typename>
struct s {};
template <typename T_>
class t : s<T_> {};
extern template class t<char>;
template class __declspec(dllexport) t<char>;
// CHECK-MS: dllexport {{.*}} @"\01??4?$t@D@@QAEAAV0@ABV0@@Z"
// CHECK-MS: dllexport {{.*}} @"\01??4?$s@D@@QAEAAU0@ABU0@@Z"
// CHECK-IA: dllexport {{.*}} @_ZN1tIcEaSERKS0_
// CHECK-IA: dllexport {{.*}} @_ZN1sIcEaSERKS0_