replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove two convenience constructors because they're now private, and the 

private implementation doesn't really need the convenience.

llvm-svn: 52629
This commit is contained in:
Dan Gohman 2008-06-23 16:48:17 +00:00
parent 031f0bba15
commit 210e6c1876
2 changed files with 4 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
llvm/include/llvm/Instructions.h
View File

@ -1520,13 +1520,6 @@ class ExtractValueInst : public UnaryInstruction {
InputIterator IdxBegin, InputIterator IdxEnd,
const std::string &Name, BasicBlock *InsertAtEnd);
/// Constructors - These two constructors are convenience methods because one
/// and two index extractvalue instructions are so common.
ExtractValueInst(Value *Agg, unsigned Idx, const std::string &Name = "",
Instruction *InsertBefore = 0);
ExtractValueInst(Value *Agg, unsigned Idx,
const std::string &Name, BasicBlock *InsertAtEnd);
// allocate space for exactly one operand
void *operator new(size_t s) {
return User::operator new(s, 1);
@ -1555,12 +1548,14 @@ public:
static ExtractValueInst *Create(Value *Agg, unsigned Idx,
const std::string &Name = "",
Instruction *InsertBefore = 0) {
return new ExtractValueInst(Agg, Idx, Name, InsertBefore);
unsigned Idxs[1] = { Idx };
return new ExtractValueInst(Agg, Idxs, Idxs + 1, Name, InsertBefore);
}
static ExtractValueInst *Create(Value *Agg, unsigned Idx,
const std::string &Name,
BasicBlock *InsertAtEnd) {
return new ExtractValueInst(Agg, Idx, Name, InsertAtEnd);
unsigned Idxs[1] = { Idx };
return new ExtractValueInst(Agg, Idxs, Idxs + 1, Name, InsertAtEnd);
}
virtual ExtractValueInst *clone() const;

18
llvm/lib/VMCore/Instructions.cpp
View File

@ -1465,24 +1465,6 @@ const Type* ExtractValueInst::getIndexedType(const Type *Agg,
return getIndexedType(Agg, &Idx, 1);
}
ExtractValueInst::ExtractValueInst(Value *Agg,
unsigned Idx,
const std::string &Name,
BasicBlock *InsertAtEnd)
: UnaryInstruction(checkType(getIndexedType(Agg->getType(), &Idx, 1)),
ExtractValue, Agg, InsertAtEnd) {
init(Idx, Name);
}
ExtractValueInst::ExtractValueInst(Value *Agg,
unsigned Idx,
const std::string &Name,
Instruction *InsertBefore)
: UnaryInstruction(checkType(getIndexedType(Agg->getType(), &Idx, 1)),
ExtractValue, Agg, InsertBefore) {
init(Idx, Name);
}
//===----------------------------------------------------------------------===//
// BinaryOperator Class
//===----------------------------------------------------------------------===//