replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

LowerTypeTests: Ignore external globals with type metadata. 

Thanks to Davide Italiano for finding the problem and providing a test case.

llvm-svn: 293119
This commit is contained in:
Peter Collingbourne 2017-01-26 00:32:15 +00:00
parent 7c021afef2
commit 1df6e858ef
2 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
llvm/lib/Transforms/IPO/LowerTypeTests.cpp
View File

@ -878,9 +878,9 @@ void LowerTypeTestsModule::verifyTypeMDNode(GlobalObject *GO, MDNode *Type) {
report_fatal_error(
"A member of a type identifier may not have an explicit section");
if (isa<GlobalVariable>(GO) && GO->isDeclarationForLinker())
report_fatal_error(
"A global var member of a type identifier must be a definition");
// FIXME: We previously checked that global var member of a type identifier
// must be a definition, but the IR linker may leave type metadata on
// declarations. We should restore this check after fixing PR31759.
auto OffsetConstMD = dyn_cast<ConstantAsMetadata>(Type->getOperand(0));
if (!OffsetConstMD)
@ -1375,6 +1375,9 @@ bool LowerTypeTestsModule::lower() {
unsigned I = 0;
SmallVector<MDNode *, 2> Types;
for (GlobalObject &GO : M.global_objects()) {
if (isa<GlobalVariable>(GO) && GO.isDeclarationForLinker())
continue;
Types.clear();
GO.getMetadata(LLVMContext::MD_type, Types);
if (Types.empty())

14
llvm/test/Transforms/LowerTypeTests/external-global.ll Normal file
View File

@ -0,0 +1,14 @@
; RUN: opt -S -lowertypetests -lowertypetests-summary-action=export -o - %s | FileCheck %s
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-scei-ps4"
; CHECK: @dipsy = external
@dipsy = external constant i8, !type !0
define void @tinkywinky() {
store i8* @dipsy, i8** undef
ret void
}
!0 = !{i64 16, !"teletubbies"}