replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

When synthesizing implicit copy/move constructors and copy/move assignment 

operators, don't make an initializer or sub-operation for zero-width
bitfields.

llvm-svn: 133221
This commit is contained in:
John McCall 2011-06-17 00:18:42 +00:00
parent 66773c3398
commit 1b1a1dbbe7
2 changed files with 24 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
clang/lib/Sema/SemaDeclCXX.cpp
View File

@ -1972,6 +1972,11 @@ BuildImplicitMemberInitializer(Sema &SemaRef, CXXConstructorDecl *Constructor,
if (ImplicitInitKind == IIK_Copy) {
ParmVarDecl *Param = Constructor->getParamDecl(0);
QualType ParamType = Param->getType().getNonReferenceType();
// Suppress copying zero-width bitfields.
if (const Expr *Width = Field->getBitWidth())
if (Width->EvaluateAsInt(SemaRef.Context) == 0)
return false;
Expr *MemberExprBase =
DeclRefExpr::Create(SemaRef.Context, NestedNameSpecifierLoc(), Param,
@ -2256,11 +2261,10 @@ Sema::SetDelegatingInitializer(CXXConstructorDecl *Constructor,
return false;
}
bool
Sema::SetCtorInitializers(CXXConstructorDecl *Constructor,
CXXCtorInitializer **Initializers,
unsigned NumInitializers,
bool AnyErrors) {
bool Sema::SetCtorInitializers(CXXConstructorDecl *Constructor,
CXXCtorInitializer **Initializers,
unsigned NumInitializers,
bool AnyErrors) {
if (Constructor->getDeclContext()->isDependentContext()) {
// Just store the initializers as written, they will be checked during
// instantiation.
@ -7011,6 +7015,11 @@ void Sema::DefineImplicitCopyAssignment(SourceLocation CurrentLocation,
Invalid = true;
continue;
}
// Suppress assigning zero-width bitfields.
if (const Expr *Width = Field->getBitWidth())
if (Width->EvaluateAsInt(Context) == 0)
continue;
QualType FieldType = Field->getType().getNonReferenceType();
if (FieldType->isIncompleteArrayType()) {

10
clang/test/CodeGenCXX/implicit-copy-constructor.cpp
View File

@ -70,3 +70,13 @@ void test_X2()
pimpl pdata;
pdata.f0( new impl(*i));
}
// rdar://problem/9598341
namespace test3 {
struct A { A(const A&); A&operator=(const A&); };
struct B { A a; unsigned : 0; };
void test(const B &x) {
B y = x;
y = x;
}
}