replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix the AsmWriter to not print extra spaces after parameter attributes. 

llvm-svn: 54351
This commit is contained in:
Dan Gohman 2008-08-05 15:51:44 +00:00
parent 3da016d137
commit 1a70bcc388
4 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/VMCore/AsmWriter.cpp
View File

@ -1385,7 +1385,7 @@ void AssemblyWriter::printInstruction(const Instruction &I) {
Out << " )";
if (PAL.getParamAttrs(0) != ParamAttr::None)
Out << " " << ParamAttr::getAsString(PAL.getParamAttrs(0));
Out << ' ' << ParamAttr::getAsString(PAL.getParamAttrs(0));
Out << "\n\t\t\tto";
writeOperand(II->getNormalDest(), true);
Out << " unwind";

2
llvm/lib/VMCore/ParameterAttributes.cpp
View File

@ -52,6 +52,8 @@ std::string ParamAttr::getAsString(ParameterAttributes Attrs) {
Result += utostr((Attrs & ParamAttr::Alignment) >> 16);
Result += " ";
}
// Trim the trailing space.
Result.erase(Result.end()-1);
return Result;
}

8
llvm/lib/VMCore/Verifier.cpp
View File

@ -404,18 +404,18 @@ void Verifier::VerifyAttrs(ParameterAttributes Attrs, const Type *Ty,
if (isReturnValue) {
ParameterAttributes RetI = Attrs & ParamAttr::ParameterOnly;
Assert1(!RetI, "Attribute " + ParamAttr::getAsString(RetI) +
"does not apply to return values!", V);
" does not apply to return values!", V);
} else {
ParameterAttributes ParmI = Attrs & ParamAttr::ReturnOnly;
Assert1(!ParmI, "Attribute " + ParamAttr::getAsString(ParmI) +
"only applies to return values!", V);
" only applies to return values!", V);
}
for (unsigned i = 0;
i < array_lengthof(ParamAttr::MutuallyIncompatible); ++i) {
ParameterAttributes MutI = Attrs & ParamAttr::MutuallyIncompatible[i];
Assert1(!(MutI & (MutI - 1)), "Attributes " +
ParamAttr::getAsString(MutI) + "are incompatible!", V);
ParamAttr::getAsString(MutI) + " are incompatible!", V);
}
ParameterAttributes TypeI = Attrs & ParamAttr::typeIncompatible(Ty);
@ -931,7 +931,7 @@ void Verifier::VerifyCallSite(CallSite CS) {
ParameterAttributes VArgI = Attr & ParamAttr::VarArgsIncompatible;
Assert1(!VArgI, "Attribute " + ParamAttr::getAsString(VArgI) +
"cannot be used for vararg call arguments!", I);
" cannot be used for vararg call arguments!", I);
}
visitInstruction(*I);

2
llvm/test/Assembler/2006-05-26-VarargsCallEncode.ll
View File

@ -1,4 +1,4 @@
; RUN: llvm-as < %s | llvm-dis | grep {tail call void.*sret null}
; RUN: llvm-as < %s | llvm-dis | grep {tail call void.*sret null}
declare void @foo({ }* sret , ...)