replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Some optimizations done by globalopt are safe only for internal linkage, not 

linkonce linkage. For example, it is not valid to add unnamed_addr.

This also fixes a crash in g++.dg/opt/static5.C.

llvm-svn: 158528
This commit is contained in:
Rafael Espindola 2012-06-15 18:00:24 +00:00
parent a15a224db0
commit 1821c6c3b0
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/lib/Transforms/IPO/GlobalOpt.cpp
View File

@ -1729,6 +1729,9 @@ bool GlobalOpt::ProcessGlobal(GlobalVariable *GV,
return true;
}
if (!GV->hasLocalLinkage())
return false;
SmallPtrSet<const PHINode*, 16> PHIUsers;
GlobalStatus GS;

12
llvm/test/Transforms/GlobalOpt/unnamed-addr.ll
View File

@ -4,11 +4,23 @@
@b = internal global i32 0, align 4
@c = internal global i32 0, align 4
@d = internal constant [4 x i8] c"foo\00", align 1
@e = linkonce_odr global i32 0
; CHECK: @a = internal global i32 0, align 4
; CHECK: @b = internal global i32 0, align 4
; CHECK: @c = internal unnamed_addr global i32 0, align 4
; CHECK: @d = internal unnamed_addr constant [4 x i8] c"foo\00", align 1
; CHECK: @e = linkonce_odr global i32 0
define i32 @get_e() {
%t = load i32* @e
ret i32 %t
}
define void @set_e(i32 %x) {
store i32 %x, i32* @e
ret void
}
define i1 @bah(i64 %i) nounwind readonly optsize ssp {
entry: