replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

WholeProgramDevirt: Check that VCP candidate functions are defined before evaluating them. 

This was crashing before.

llvm-svn: 294666
This commit is contained in:
Peter Collingbourne 2017-02-09 23:46:26 +00:00
parent d0d8daa37c
commit 17febdbb25
2 changed files with 37 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp
View File

@ -571,12 +571,12 @@ bool DevirtModule::tryVirtualConstProp(
if (BitWidth > 64)
return false;
// Make sure that each function does not access memory, takes at least one
// argument, does not use its first argument (which we assume is 'this'),
// and has the same return type.
// Make sure that each function is defined, does not access memory, takes at
// least one argument, does not use its first argument (which we assume is
// 'this'), and has the same return type.
for (VirtualCallTarget &Target : TargetsForSlot) {
if (!Target.Fn->doesNotAccessMemory() || Target.Fn->arg_empty() ||
!Target.Fn->arg_begin()->use_empty() ||
if (Target.Fn->isDeclaration() || !Target.Fn->doesNotAccessMemory() ||
Target.Fn->arg_empty() || !Target.Fn->arg_begin()->use_empty() ||
Target.Fn->getReturnType() != RetType)
return false;
}

32
llvm/test/Transforms/WholeProgramDevirt/vcp-decl.ll Normal file
View File

@ -0,0 +1,32 @@
; RUN: opt -S -wholeprogramdevirt %s | FileCheck %s
target datalayout = "e-p:64:64"
target triple = "x86_64-unknown-linux-gnu"
@vt1 = constant [1 x i8*] [i8* bitcast (i32 (i8*, i32)* @vf1 to i8*)], !type !0
@vt2 = constant [1 x i8*] [i8* bitcast (i32 (i8*, i32)* @vf2 to i8*)], !type !0
declare i32 @vf1(i8* %this, i32 %arg) readnone
define i32 @vf2(i8* %this, i32 %arg) readnone {
ret i32 %arg
}
; CHECK: define i32 @fn
define i32 @fn(i8* %obj) {
%vtableptr = bitcast i8* %obj to [1 x i8*]**
%vtable = load [1 x i8*]*, [1 x i8*]** %vtableptr
%vtablei8 = bitcast [1 x i8*]* %vtable to i8*
%p = call i1 @llvm.type.test(i8* %vtablei8, metadata !"typeid")
call void @llvm.assume(i1 %p)
%fptrptr = getelementptr [1 x i8*], [1 x i8*]* %vtable, i32 0, i32 0
%fptr = load i8*, i8** %fptrptr
%fptr_casted = bitcast i8* %fptr to i32 (i8*, i32)*
; CHECK: call i32 %
%result = call i32 %fptr_casted(i8* %obj, i32 1)
ret i32 %result
}
declare i1 @llvm.type.test(i8*, metadata)
declare void @llvm.assume(i1)
!0 = !{i32 0, !"typeid"}