replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[x86] Remove the FIXME that was implemented in r214628. Managed to 

forget to update the comment here... =/

llvm-svn: 214630
This commit is contained in:
Chandler Carruth 2014-08-02 11:34:23 +00:00
parent bec57b406d
commit 16c13cad35
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/Target/X86/X86ISelLowering.cpp
View File

@ -18945,10 +18945,6 @@ static bool combineX86ShuffleChain(SDValue Op, SDValue Root, ArrayRef<int> Mask,
/// This should never be an issue in practice as the shuffle lowering doesn't
/// produce sequences of more than 8 instructions.
///
/// FIXME: Currently, we don't collapse instructions *into* PSHUFB. We should,
/// and we should do so more aggressively than we form PSHUFB because once we
/// have a PSHUFB, we might as well do as much shuffling as we can.
///
/// FIXME: We will currently miss some cases where the redundant shuffling
/// would simplify under the threshold for PSHUFB formation because of
/// combine-ordering. To fix this, we should do the redundant instruction