replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

COFF: replace a magic number and assert more 

Assert that the size of the MD5 result is the same size as the signature
field being populated.  Use the sizeof operator to determine the size of
the field being written rather than hardcoding it to the magic number
16.  NFC.

llvm-svn: 290764
This commit is contained in:
Saleem Abdulrasool 2016-12-30 19:02:04 +00:00
parent da36215017
commit 1618a653f3
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lld/COFF/Writer.cpp
View File

@ -828,7 +828,10 @@ void Writer::writeBuildId() {
assert(BuildId->DI->Signature.CVSignature == OMF::Signature::PDB70 &&
"only PDB 7.0 is supported");
memcpy(BuildId->DI->PDB70.Signature, Res, 16);
assert(sizeof(Res) == sizeof(BuildId->DI->PDB70.Signature) &&
"signature size mismatch");
memcpy(BuildId->DI->PDB70.Signature, Res,
sizeof(codeview::PDB70DebugInfo::Signature));
// TODO(compnerd) track the Age
BuildId->DI->PDB70.Age = 1;
}