[Hexagon] Crash in instruction selection for insert_vector_elt for HVX

A wrong type was passed to insertVector, causing an out-of-bounds value
to be added an an operand to HexagonISD::INSERT. This later failed in
instruction selection.

llvm-svn: 320369
This commit is contained in:
Krzysztof Parzyszek 2017-12-11 14:46:06 +00:00
parent 50d37a1129
commit 152414595b
2 changed files with 24 additions and 1 deletions

View File

@ -280,7 +280,7 @@ HexagonTargetLowering::LowerHvxInsertElement(SDValue Op, SelectionDAG &DAG)
SDValue SubIdx = getIndexInWord32(IdxV, ElemTy, DAG);
MVT SubVecTy = tyVector(ty(Ext), ElemTy);
SDValue Ins = insertVector(DAG.getBitcast(SubVecTy, Ext),
ValV, SubIdx, dl, SubVecTy, DAG);
ValV, SubIdx, dl, ElemTy, DAG);
// 3. Insert the 32-bit word back into the original vector.
return InsertWord(VecV, Ins, ByteIdx);

View File

@ -0,0 +1,23 @@
; RUN: llc -march=hexagon < %s | FileCheck %s
; REQUIRES: asserts
; Check that this testcase compiles successfully.
; CHECK: vextract
target datalayout = "e-m:e-p:32:32:32-a:0-n16:32-i64:64:64-i32:32:32-i16:16:16-i1:8:8-f32:32:32-f64:64:64-v32:32:32-v64:64:64-v512:512:512-v1024:1024:1024-v2048:2048:2048"
target triple = "hexagon-unknown--elf"
define void @fred() local_unnamed_addr #0 {
b0:
%v1 = load <64 x i8>, <64 x i8>* undef, align 64
%v2 = insertelement <64 x i8> %v1, i8 0, i32 0
br label %b3
b3: ; preds = %b3, %b0
%v4 = phi <64 x i8> [ %v2, %b0 ], [ %v6, %b3 ]
%v5 = extractelement <64 x i8> %v4, i32 0
%v6 = insertelement <64 x i8> %v4, i8 undef, i32 0
br label %b3
}
attributes #0 = { "target-cpu"="hexagonv60" "target-features"="+hvx,+hvx-length64b" }