replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

PR5520: Make sure to check whether the base type is complete before looking for 

operator->.

llvm-svn: 89180
This commit is contained in:
Eli Friedman 2009-11-18 01:28:03 +00:00
parent 49939c2914
commit 132e70bfa4
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang/lib/Sema/SemaOverload.cpp
View File

@ -5503,6 +5503,11 @@ Sema::BuildOverloadedArrowExpr(Scope *S, ExprArg BaseIn, SourceLocation OpLoc) {
OverloadCandidateSet CandidateSet; OverloadCandidateSet CandidateSet;
const RecordType *BaseRecord = Base->getType()->getAs<RecordType>(); const RecordType *BaseRecord = Base->getType()->getAs<RecordType>();
if (RequireCompleteType(Base->getLocStart(), Base->getType(),
PDiag(diag::err_typecheck_incomplete_tag)
<< Base->getSourceRange()))
return ExprError();
LookupResult R(*this, OpName, OpLoc, LookupOrdinaryName); LookupResult R(*this, OpName, OpLoc, LookupOrdinaryName);
LookupQualifiedName(R, BaseRecord->getDecl()); LookupQualifiedName(R, BaseRecord->getDecl());
R.suppressDiagnostics(); R.suppressDiagnostics();

5
clang/test/SemaCXX/arrow-operator.cpp
View File

@ -16,7 +16,10 @@ struct C : A, B {
struct D : A { }; struct D : A { };
void f(C &c, D& d) { struct E; // expected-note {{forward declaration of 'struct E'}}
void f(C &c, D& d, E& e) {
c->f(); // expected-error{{use of overloaded operator '->' is ambiguous}} c->f(); // expected-error{{use of overloaded operator '->' is ambiguous}}
d->f(); d->f();
e->f(); // expected-error{{incomplete definition of type}}
} }