replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[flang] bugfixing and review comments 

Original-commit: flang-compiler/f18@6df4a52d6b
Reviewed-on: https://github.com/flang-compiler/f18/pull/225
Tree-same-pre-rewrite: false
This commit is contained in:
peter klausler 2018-11-14 11:57:47 -08:00
parent 972d2d52c5
commit 12b0f643ab
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
flang/documentation/C++style.md
View File

@ -203,7 +203,7 @@ A feature matrix:
| pointer | nullable | default null | owning | reassignable | copyable | undefined type ok? |
| ------- | -------- | ------------ | ------ | ------------ | -------- | ------------------ |
| `*p` | yes | no | no | yes | shallowly | yes |
| `&r` | no | n/a | no | no | shallowly | no |
| `&r` | no | n/a | no | no | shallowly | yes |
| `unique_ptr<>` | yes | yes | yes | yes | no | no |
| `shared_ptr<>` | yes | yes | yes | yes | shallowly | no |
| `OwningPointer<>` | yes | yes | yes | yes | no | yes |

4
flang/lib/parser/characters.h
View File

@ -103,7 +103,7 @@ inline constexpr char HexadecimalDigitValue(char ch) {
inline constexpr std::optional<char> BackslashEscapeValue(char ch) {
switch (ch) {
case 'a': return {'\a'};
// case 'a': return {'\a'}; // pgf90 has no \a
case 'b': return {'\b'};
case 'f': return {'\f'};
case 'n': return {'\n'};
@ -119,7 +119,7 @@ inline constexpr std::optional<char> BackslashEscapeValue(char ch) {
inline constexpr std::optional<char> BackslashEscapeChar(char ch) {
switch (ch) {
case '\a': return {'a'};
// case '\a': return {'a'}; // pgf90 has no \a
case '\b': return {'b'};
case '\f': return {'f'};
case '\n': return {'n'};