From 12679470bfe700d232d30f28eefc5ecb6f730cce Mon Sep 17 00:00:00 2001 From: Owen Anderson Date: Sun, 7 Dec 2008 05:33:18 +0000 Subject: [PATCH] Switch to top-down mode and fix a crasher this exposed caused by an error in the live interval updating. llvm-svn: 60652 --- llvm/lib/CodeGen/PreAllocSplitting.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/llvm/lib/CodeGen/PreAllocSplitting.cpp b/llvm/lib/CodeGen/PreAllocSplitting.cpp index 160144599c7d..fe1efe5c9576 100644 --- a/llvm/lib/CodeGen/PreAllocSplitting.cpp +++ b/llvm/lib/CodeGen/PreAllocSplitting.cpp @@ -442,6 +442,9 @@ PreAllocSplitting::UpdateRegisterInterval(VNInfo *ValNo, unsigned SpillIndex, SE = MBB->succ_end(); SI != SE; ++SI) WorkList.push_back(*SI); + SmallPtrSet ProcessedBlocks; + ProcessedBlocks.insert(MBB); + while (!WorkList.empty()) { MBB = WorkList.back(); WorkList.pop_back(); @@ -459,6 +462,13 @@ PreAllocSplitting::UpdateRegisterInterval(VNInfo *ValNo, unsigned SpillIndex, } Processed.insert(LR); } + + ProcessedBlocks.insert(MBB); + if (LR) + for (MachineBasicBlock::succ_iterator SI = MBB->succ_begin(), + SE = MBB->succ_end(); SI != SE; ++SI) + if (!ProcessedBlocks.count(*SI)) + WorkList.push_back(*SI); } for (LiveInterval::iterator I = CurrLI->begin(), E = CurrLI->end(); @@ -1039,7 +1049,7 @@ bool PreAllocSplitting::runOnMachineFunction(MachineFunction &MF) { // Make sure blocks are numbered in order. MF.RenumberBlocks(); -#if 0 +#if 1 // FIXME: Go top down. MachineBasicBlock *Entry = MF.begin(); SmallPtrSet Visited;