replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[X86][AsmParser] Emit an error when RIP-relative instructions are used in 32-bit mode 

Right now, when we use RIP-relative instructions in 32-bit mode, we'll just
assert and crash.

This adds an error message which tells the user that they can't do that in
32-bit mode, so that we don't crash (and also can see the issue outside of
assert builds).

llvm-svn: 335658
This commit is contained in:
Jessica Paquette 2018-06-26 20:33:46 +00:00
parent ee59c5e922
commit 0e40d4bfc3
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
View File

@ -974,6 +974,13 @@ static unsigned MatchRegisterName(StringRef Name);
static bool CheckBaseRegAndIndexRegAndScale(unsigned BaseReg, unsigned IndexReg,
unsigned Scale, bool Is64BitMode,
StringRef &ErrMsg) {
// RIP/EIP-relative addressing is only supported in 64-bit mode.
if (!Is64BitMode && BaseReg != 0 &&
(BaseReg == X86::RIP || BaseReg == X86::EIP)) {
ErrMsg = "RIP-relative addressing requires 64-bit mode";
return true;
}
// If we have both a base register and an index register make sure they are
// both 64-bit or 32-bit registers.
// To support VSIB, IndexReg can be 128-bit or 256-bit registers.

13
llvm/test/CodeGen/X86/eip-addressing-i386.ll Normal file
View File

@ -0,0 +1,13 @@
; RUN: not llc -mtriple i386-apple-- -o /dev/null < %s 2>&1| FileCheck %s
; CHECK: <inline asm>:1:13: error: RIP-relative addressing requires 64-bit mode
; CHECK-NEXT: jmpl *_foo(%eip)
; Make sure that we emit an error if we encounter RIP-relative instructions in
; 32-bit mode.
define i32 @foo() { ret i32 0 }
define i32 @bar() {
call void asm sideeffect "jmpl *_foo(%eip)\0A", "~{dirflag},~{fpsr},~{flags}"()
ret i32 0
}