From 0ccc0b1a5f32edcddc61286d10f0521ca648ef11 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 7 Mar 2019 17:27:33 +0000 Subject: [PATCH] [Reproducers] Disable registering lldb::thread_t everywhere As discussed on the mailing list, default serialization for thread ids is not correct, even if they're represented as basic types. I'm purposely leaving the corresponding record macros in place so that we don't break the API boundary detection. llvm-svn: 355610 --- lldb/source/API/SBReproducer.cpp | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/lldb/source/API/SBReproducer.cpp b/lldb/source/API/SBReproducer.cpp index 05a8a5ff9a39..7980f1505b0b 100644 --- a/lldb/source/API/SBReproducer.cpp +++ b/lldb/source/API/SBReproducer.cpp @@ -1116,17 +1116,6 @@ SBRegistry::SBRegistry() { LLDB_REGISTER_STATIC_METHOD(lldb::SBFileSpec, SBHostOS, GetUserHomeDirectory, ()); LLDB_REGISTER_STATIC_METHOD(void, SBHostOS, ThreadCreated, (const char *)); -#ifndef _WIN32 - // FIXME: On Windows, lldb::thread_t is just a void*, so the we will try to - // allocate an object of type void when deserializing. - LLDB_REGISTER_STATIC_METHOD(bool, SBHostOS, ThreadCancel, - (lldb::thread_t, lldb::SBError *)); - LLDB_REGISTER_STATIC_METHOD(bool, SBHostOS, ThreadDetach, - (lldb::thread_t, lldb::SBError *)); - LLDB_REGISTER_STATIC_METHOD( - bool, SBHostOS, ThreadJoin, - (lldb::thread_t, lldb::thread_result_t *, lldb::SBError *)); -#endif } { LLDB_REGISTER_CONSTRUCTOR(SBInstruction, ());