[GlobalISel][AArch64] Legalize/select G_(S/Z/ANY)_EXT for v8s8s

This adds legalization for G_SEXT, G_ZEXT, and G_ANYEXT for v8s8s.

We were falling back on G_ZEXT in arm64-vabs.ll before, preventing us from
selecting the @llvm.aarch64.neon.sabd.v8i8 intrinsic.

This adds legalizer support for those 3, which gives us selection via the
importer. Update the relevant tests (legalize-ext.mir, select-int-ext.mir) and
add a GISel line to arm64-vabs.ll.

Differential Revision: https://reviews.llvm.org/D60881

llvm-svn: 358715
This commit is contained in:
Jessica Paquette 2019-04-18 21:15:48 +00:00
parent 3b5119c684
commit 0aa9b453c4
4 changed files with 147 additions and 2 deletions

View File

@ -316,7 +316,8 @@ AArch64LegalizerInfo::AArch64LegalizerInfo(const AArch64Subtarget &ST) {
// Extensions
getActionDefinitionsBuilder({G_ZEXT, G_SEXT, G_ANYEXT})
.legalForCartesianProduct({s8, s16, s32, s64}, {s1, s8, s16, s32});
.legalForCartesianProduct({s8, s16, s32, s64}, {s1, s8, s16, s32})
.legalFor({v8s16, v8s8});
getActionDefinitionsBuilder(G_TRUNC).alwaysLegal();

View File

@ -169,3 +169,61 @@ body: |
$w0 = COPY %3(s32)
...
---
name: test_zext_v8s16_from_v8s8
alignment: 2
tracksRegLiveness: true
machineFunctionInfo: {}
body: |
bb.0:
liveins: $d0
; CHECK-LABEL: name: test_zext_v8s16_from_v8s8
; CHECK: liveins: $d0
; CHECK: [[COPY:%[0-9]+]]:fpr(<8 x s8>) = COPY $d0
; CHECK: [[ZEXT:%[0-9]+]]:_(<8 x s16>) = G_ZEXT [[COPY]](<8 x s8>)
; CHECK: $q0 = COPY [[ZEXT]](<8 x s16>)
; CHECK: RET_ReallyLR implicit $q0
%1:fpr(<8 x s8>) = COPY $d0
%2:_(<8 x s16>) = G_ZEXT %1(<8 x s8>)
$q0 = COPY %2(<8 x s16>)
RET_ReallyLR implicit $q0
...
---
name: test_sext_v8s16_from_v8s8
alignment: 2
tracksRegLiveness: true
machineFunctionInfo: {}
body: |
bb.0:
liveins: $d0
; CHECK-LABEL: name: test_sext_v8s16_from_v8s8
; CHECK: liveins: $d0
; CHECK: [[COPY:%[0-9]+]]:fpr(<8 x s8>) = COPY $d0
; CHECK: [[SEXT:%[0-9]+]]:_(<8 x s16>) = G_SEXT [[COPY]](<8 x s8>)
; CHECK: $q0 = COPY [[SEXT]](<8 x s16>)
; CHECK: RET_ReallyLR implicit $q0
%1:fpr(<8 x s8>) = COPY $d0
%2:_(<8 x s16>) = G_SEXT %1(<8 x s8>)
$q0 = COPY %2(<8 x s16>)
RET_ReallyLR implicit $q0
...
---
name: test_anyext_v8s16_from_v8s8
alignment: 2
tracksRegLiveness: true
machineFunctionInfo: {}
body: |
bb.0:
liveins: $d0
; CHECK-LABEL: name: test_anyext_v8s16_from_v8s8
; CHECK: liveins: $d0
; CHECK: [[COPY:%[0-9]+]]:fpr(<8 x s8>) = COPY $d0
; CHECK: [[ANYEXT:%[0-9]+]]:_(<8 x s16>) = G_ANYEXT [[COPY]](<8 x s8>)
; CHECK: $q0 = COPY [[ANYEXT]](<8 x s16>)
; CHECK: RET_ReallyLR implicit $q0
%1:fpr(<8 x s8>) = COPY $d0
%2:_(<8 x s16>) = G_ANYEXT %1(<8 x s8>)
$q0 = COPY %2(<8 x s16>)
RET_ReallyLR implicit $q0

View File

@ -6,16 +6,19 @@
define void @anyext_s64_from_s32() { ret void }
define void @anyext_s32_from_s8() { ret void }
define void @anyext_v8s16_from_v8s8() { ret void }
define void @zext_s64_from_s32() { ret void }
define void @zext_s32_from_s16() { ret void }
define void @zext_s32_from_s8() { ret void }
define void @zext_s16_from_s8() { ret void }
define void @zext_v8s16_from_v8s8() { ret void }
define void @sext_s64_from_s32() { ret void }
define void @sext_s32_from_s16() { ret void }
define void @sext_s32_from_s8() { ret void }
define void @sext_s16_from_s8() { ret void }
define void @sext_v8s16_from_v8s8() { ret void }
...
---
@ -63,6 +66,31 @@ body: |
$w0 = COPY %1(s32)
...
---
name: anyext_v8s16_from_v8s8
alignment: 2
legalized: true
regBankSelected: true
tracksRegLiveness: true
registers:
- { id: 0, class: fpr }
- { id: 1, class: fpr }
machineFunctionInfo: {}
body: |
bb.0:
liveins: $d0
; CHECK-LABEL: name: anyext_v8s16_from_v8s8
; CHECK: liveins: $d0
; CHECK: [[COPY:%[0-9]+]]:fpr64 = COPY $d0
; CHECK: [[USHLLv8i8_shift:%[0-9]+]]:fpr128 = USHLLv8i8_shift [[COPY]], 0
; CHECK: $q0 = COPY [[USHLLv8i8_shift]]
; CHECK: RET_ReallyLR implicit $q0
%0:fpr(<8 x s8>) = COPY $d0
%1:fpr(<8 x s16>) = G_ANYEXT %0(<8 x s8>)
$q0 = COPY %1(<8 x s16>)
RET_ReallyLR implicit $q0
---
name: zext_s64_from_s32
legalized: true
@ -157,6 +185,33 @@ body: |
$w0 = COPY %3(s32)
...
---
name: zext_v8s16_from_v8s8
alignment: 2
legalized: true
regBankSelected: true
tracksRegLiveness: true
registers:
- { id: 0, class: fpr }
- { id: 1, class: fpr }
machineFunctionInfo: {}
body: |
bb.0:
liveins: $d0
; CHECK-LABEL: name: zext_v8s16_from_v8s8
; CHECK: liveins: $d0
; CHECK: [[COPY:%[0-9]+]]:fpr64 = COPY $d0
; CHECK: [[USHLLv8i8_shift:%[0-9]+]]:fpr128 = USHLLv8i8_shift [[COPY]], 0
; CHECK: $q0 = COPY [[USHLLv8i8_shift]]
; CHECK: RET_ReallyLR implicit $q0
%0:fpr(<8 x s8>) = COPY $d0
%1:fpr(<8 x s16>) = G_ZEXT %0(<8 x s8>)
$q0 = COPY %1(<8 x s16>)
RET_ReallyLR implicit $q0
...
---
name: sext_s64_from_s32
legalized: true
@ -250,3 +305,30 @@ body: |
%3:gpr(s32) = G_ANYEXT %1
$w0 = COPY %3(s32)
...
---
name: sext_v8s16_from_v8s8
alignment: 2
legalized: true
regBankSelected: true
tracksRegLiveness: true
registers:
- { id: 0, class: fpr }
- { id: 1, class: fpr }
machineFunctionInfo: {}
body: |
bb.0:
liveins: $d0
; CHECK-LABEL: name: sext_v8s16_from_v8s8
; CHECK: liveins: $d0
; CHECK: [[COPY:%[0-9]+]]:fpr64 = COPY $d0
; CHECK: [[SSHLLv8i8_shift:%[0-9]+]]:fpr128 = SSHLLv8i8_shift [[COPY]], 0
; CHECK: $q0 = COPY [[SSHLLv8i8_shift]]
; CHECK: RET_ReallyLR implicit $q0
%0:fpr(<8 x s8>) = COPY $d0
%1:fpr(<8 x s16>) = G_SEXT %0(<8 x s8>)
$q0 = COPY %1(<8 x s16>)
RET_ReallyLR implicit $q0
...

View File

@ -1,9 +1,13 @@
; RUN: llc < %s -mtriple=arm64-eabi -aarch64-neon-syntax=apple | FileCheck %s
; RUN: llc < %s -global-isel -global-isel-abort=2 -pass-remarks-missed=gisel* -mtriple=arm64-eabi -aarch64-neon-syntax=apple 2>&1 | FileCheck %s --check-prefixes=GISEL,FALLBACK
; FALLBACK-NOT: remark:{{.*}}(<8 x s16>) = G_ZEXT %4:_(<8 x s8>)
; FALLBACK-NOT: remark:{{.*}} sabdl8h
define <8 x i16> @sabdl8h(<8 x i8>* %A, <8 x i8>* %B) nounwind {
;CHECK-LABEL: sabdl8h:
;CHECK: sabdl.8h
;GISEL-LABEL: sabdl8h:
;GISEL: sabdl.8h
%tmp1 = load <8 x i8>, <8 x i8>* %A
%tmp2 = load <8 x i8>, <8 x i8>* %B
%tmp3 = call <8 x i8> @llvm.aarch64.neon.sabd.v8i8(<8 x i8> %tmp1, <8 x i8> %tmp2)